Skip to content

Commit 907a597

Browse files
authored
fix(app): remove duplicate svg render (#21126)
# Overview looks like we were rendering the svg on the modules like twice? oops. ## Test Plan and Hands on Testing please smoke test all the modules with labware and make sure things work as expected. i smoke tested a bit and it worked with stacker + thermocycler + temperature module. but i don't feel confident still ## Changelog remove a probable double svg render of the labware on the module ## Risk assessment high - this is the last PV bug to get into RS 9.0.0
1 parent 6602766 commit 907a597

File tree

1 file changed

+1
-30
lines changed

1 file changed

+1
-30
lines changed

app/src/organisms/Desktop/ProtocolVisualization/DeckView/DeckViewModules.tsx

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
import { Fragment } from 'react'
22

3-
import {
4-
CenterLabwareInModuleChildSlot,
5-
COLORS,
6-
Module,
7-
} from '@opentrons/components'
3+
import { COLORS, Module } from '@opentrons/components'
84
import {
95
FLEX_STACKER_MODULE_TYPE,
106
getModuleDef,
@@ -18,7 +14,6 @@ import { getModuleInnerProps } from '../utils/getModuleInnerProps'
1814
import { getTopmostLabwareOnModuleFromStack } from '../utils/getTopmostLabwareOnModuleFromStack'
1915
import { DeckViewOverlay } from './DeckViewOverlay'
2016
import { DeckViewStacker } from './DeckViewStacker'
21-
import { LabwareOnDeck } from './LabwareOnDeck'
2217

2318
import type { Dispatch, SetStateAction } from 'react'
2419
import type { ThermocyclerVizProps } from '@opentrons/components'
@@ -107,30 +102,6 @@ export function DeckViewModules(props: DeckViewModulesProps): JSX.Element {
107102
!showLabwareCommandSummary
108103
return (
109104
<Fragment key={id}>
110-
{moduleType !== THERMOCYCLER_MODULE_TYPE &&
111-
labwareLoadedOnModuleId != null ? (
112-
<CenterLabwareInModuleChildSlot
113-
deckId={deckDef.otId}
114-
slotId={slot}
115-
moduleDefinition={moduleDef}
116-
labwareDefinition={
117-
labwareEntitiesExtended[labwareLoadedOnModuleId].def
118-
}
119-
>
120-
<LabwareOnDeck
121-
robotState={robotState}
122-
labwareDef={
123-
labwareEntitiesExtended[labwareLoadedOnModuleId].def
124-
}
125-
liquids={liquids}
126-
labwareId={labwareLoadedOnModuleId}
127-
x={0}
128-
y={0}
129-
setSelectedSlot={setSelectedSlot}
130-
setHoveredSlot={setHoveredSlot}
131-
/>
132-
</CenterLabwareInModuleChildSlot>
133-
) : null}
134105
<Module
135106
key={id}
136107
x={slotPosition[0]}

0 commit comments

Comments
 (0)