Skip to content

Commit dcf1293

Browse files
committed
format and no run on tag lint test
1 parent a00c875 commit dcf1293

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

.cursor/skills/npmjs-publish/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Do not duplicate version parsing: import **`resolve_version_input`** (or helpers
4141
`.github/workflows/npmjs-publish.yaml`:
4242

4343
- **PR** (paths): lint + test jobs, no `needs` between them
44-
- **push** `npmjs-publish@*`: publish job runs preflight with version from `github.ref`
44+
- **push** `npmjs-publish@*`: **publish** job only (preflight with version from `github.ref`), no lint or unit test jobs
4545

4646
## Monorepo build order
4747

.github/workflows/npmjs-publish.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: npmjs publish
22

3-
# PR: lint and unit tests only (file-filtered). Tag push: same jobs plus publish (tag-only).
3+
# PR: lint and unit tests only (file-filtered). Tag push: publish only (no lint/tests).
44
on:
55
pull_request:
66
paths:
@@ -24,6 +24,7 @@ env:
2424
jobs:
2525
lint:
2626
name: Lint npmjs-publish
27+
if: github.event_name == 'pull_request'
2728
runs-on: ubuntu-24.04
2829
steps:
2930
- name: Checkout Repository
@@ -44,6 +45,7 @@ jobs:
4445

4546
test:
4647
name: Unit test npmjs-publish
48+
if: github.event_name == 'pull_request'
4749
runs-on: ubuntu-24.04
4850
steps:
4951
- name: Checkout Repository

scripts/npmjs-publish/PLAN.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ todos:
2929
- **Tag:** `npmjs-publish@<semver>` for workflow and version parsing.
3030
- **Preflight:** rejects invalid semver and wrong tag prefixes; partial and full “already on registry” cases are **errors** (npm cannot overwrite an existing version).
3131
- **Build chain:** `build_packages.py` runs `make build-ts`, `shared-data lib-js`, `step-generation lib`, components `build-ts` + `lib`, protocol-visualization `build-ts` + `lib`, then optional manifest rewrite.
32-
- **Workflow** [`.github/workflows/npmjs-publish.yaml`](../../.github/workflows/npmjs-publish.yaml): PR path filters run lint + test; tag push runs publish preflight job with version from ref.
32+
- **Workflow** [`.github/workflows/npmjs-publish.yaml`](../../.github/workflows/npmjs-publish.yaml): PR path filters run lint + test; tag push runs **publish** preflight only (no lint or unit tests on the tag).
3333
- **step-generation:** npm-oriented `package.json` and `Makefile` targets (`build-ts`, `lib`, `pack`).
3434

3535
**Not done yet:**

scripts/npmjs-publish/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ make build-packages-manifests-only VERSION=1.2.3
7575
Workflow: [`.github/workflows/npmjs-publish.yaml`](../../.github/workflows/npmjs-publish.yaml)
7676

7777
- **pull_request** (paths: this workflow + `scripts/npmjs-publish/**`): **lint** and **unit test** jobs (parallel, no `needs`).
78-
- **push** tags `npmjs-publish@*`: same jobs plus **publish** job: resolve version from tag, run preflight (`publish.py`).
78+
- **push** tags `npmjs-publish@*`: **publish** job only: resolve version from tag, run preflight (`publish.py`). Lint and unit tests do not run on tag push.
7979

8080
Tag pushes use the full ref as `--version` so `publish_core.resolve_version_input` accepts it.
8181

0 commit comments

Comments
 (0)