All PR#29 comments have been addressed. Here's a summary of changes: Python Backend api.py: Removed auto-initialization side effect from GET /cancer-research/mechanisms endpoint (Comment #28). Fixed dynamic SQL in update_workspace to avoid f-string interpolation and added empty-update validation (Comment #30). assay_loader.py: Fixed docstring to correctly document return value as count of newly inserted assays (Comment #31). cancer_research_etl.py: Fixed any → Any type hint and added Any import (Comment #32). molecule_utils.py (new): Extracted shared find_molecule_by_chembl_id, find_molecule_by_pubchem_cid, find_molecule_by_smiles helpers (Comment #33). ligand_loader.py: Replaced duplicate helpers with imports from molecule_utils. Documented BindingDB loader as TODO placeholder (Comments #33, #34). curated_ligand_loader.py: Replaced duplicate helpers with imports from molecule_utils (Comment #33). Swift (macOS App) CancerResearchDownloadView.swift: Fixed race condition by replacing loadingMechanismId: Int? with loadingMechanismIds: Set<Int> (Comment #35). CancerResearchModels.swift: Added array and dictionary support to AnyCodable equality (Comment #36). DrugOutcomesView.swift: Added missing "success" case with .green color (Comment #37). LigandDetailView.swift: Removed redundant presentationMode dismiss and duplicate loadTarget call (Comments #38, #39). SimilarityAnalysisView.swift: Removed dead ligand-selection code from onAppear (Comment #40). TargetDetailView.swift: Fixed IUPHAR link to use gene symbol search instead of UniProt ID (Comment #41). BackendService.swift: Surfaced backend error fields from response models using BackendError.unknownError() (Comment #19). Already Fixed (from prior commit) Comments #1-#18, #25-#27, #29: Information exposure already fixed with logger.exception() + generic errors. Comment #24: TargetsView already uses BackendService.shared.fetchTargets(). Comment #21: Hypothesis generation already implemented.

clean up- add docs folder and scripts folder and move root level items into those folders #19

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions