Take reviewer's comment into account:

- change comment in DcSwitch.
- add r to constructor of DcSwitchImpl and add network listener call in setR.

Author: SGI-Landry

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/DcSwitch.java

@@ -9,7 +9,7 @@
 
 /**
  * A DC Switch within a DC system. A DC Switch connects two DC Nodes and can be opened or closed.
- * A DC Switch may have a non-negative resistance, which may be important for security analyses.
+ * A DC Switch may have a non-negative resistance to model losses.
  *
  * <p> To create a DcSwitch, see {@link DcSwitchAdder}
  *
@@ -49,7 +49,6 @@
  *             <td style="border: 1px solid black">Kind</td>
  *             <td style="border: 1px solid black">DcSwitchKind</td>
  *             <td style="border: 1px solid black"> - </td>
- *             <td style="border: 1px solid black">yes</td>
  *             <td style="border: 1px solid black"> - </td>
  *             <td style="border: 1px solid black">The DC switch kind: DISCONNECTOR or BREAKER</td>
  *         </tr>

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/DcSwitchAdderImpl.java

@@ -74,8 +74,17 @@ public DcSwitch add() {
         if (open == null) {
             throw new ValidationException(this, "open is not set");
         }
-        DcSwitchImpl dcSwitch = new DcSwitchImpl(networkRef, subnetworkRef, id, getName(), isFictitious(), kind, dcNode1, dcNode2, open);
-        dcSwitch.setR(this.r);
+        DcSwitchImpl dcSwitch = new DcSwitchImpl(networkRef,
+                subnetworkRef,
+                id,
+                getName(),
+                isFictitious(),
+                kind,
+                dcNode1,
+                dcNode2,
+                open,
+                this.r);
+
         getNetwork().getIndex().checkAndAdd(dcSwitch);
         getNetwork().getListeners().notifyCreation(dcSwitch);
         getParentNetwork().getDcTopologyModel().addDcSwitchToTopology(dcSwitch, dcNode1Id, dcNode2Id);

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/DcSwitchImpl.java

@@ -39,7 +39,8 @@ public class DcSwitchImpl extends AbstractIdentifiable<DcSwitch> implements DcSw
                  DcSwitchKind kind,
                  DcNode dcNode1,
                  DcNode dcNode2,
-                 boolean open) {
+                 boolean open,
+                 double r) {
         super(id, name, fictitious);
         this.networkRef = Objects.requireNonNull(ref);
         this.subnetworkRef = subnetworkRef;
@@ -52,6 +53,7 @@ public class DcSwitchImpl extends AbstractIdentifiable<DcSwitch> implements DcSw
         for (int i = 0; i < variantArraySize; i++) {
             this.open.add(open);
         }
+        this.r = r;
     }
 
     @Override
@@ -163,13 +165,16 @@ public DcSwitch setR(double r) {
         ValidationUtil.checkModifyOfRemovedEquipment(this.id, this.removed, R_ATTRIBUTE);
         ValidationUtil.checkDoubleParamPositive(this, r, R_ATTRIBUTE);
 
-        if ((r == 0.0) != (this.r == 0.0)) {
+        double oldValue = this.r;
+        this.r = r;
+
+        if ((r == 0.0) != (oldValue == 0.0)) {
             // if we change the value of r from 0 to non-zero
             // or vice versa, topology must be recomputed.
             getNetwork().dcTopologyModel.invalidateCache();
         }
+        getNetwork().getListeners().notifyUpdate(this, R_ATTRIBUTE, oldValue, r);
 
-        this.r = r;
         return this;
     }
 }