Feature: Move CRDs into separate contour-crds chart

[tsaarni]

Consider moving CRDs from contour chart to contour-crds chart, following Helm best practices
https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-2-separate-charts

[deepy]

This doesn't need to be a breaking change, helm has support for dependencies and even support for making them conditional

https://helm.sh/docs/topics/charts#chart-dependencies
https://helm.sh/docs/chart_template_guide/subcharts_and_globals/

[tsaarni]

I understand that dependencies between charts are generally discouraged, but it sounds like having dependency towards CRD chart could still be OK and reusing the current manageCRDs variable as conditional makes sense.

However, I wouldn’t be surprised if splitting one chart into multiple could still lead to backward compatibility issues in some specific upgrade or downgrade scenario. I’ve seen and heard so many horror stories that I’ve come to expect something to break with any major change 😂

[deepy]

Exactly, that's why I've tried to find the time to read up on it and do some testing before commenting further on the PR 😀

[Sefiris]

Agreed on this!

My suggestion at least having worked with many helm charts before in my clusters is that having CRDs seperated and as i suggested in the PR that was posted to remove them from the main contour chart.

I mainly say this because I don't think its weird to assume that contour is mainly used by cluster operators, and in my own use case I actually want to deploy the contour controller multiple times(external, internal only, employee access).

Gonna work on a PR for this as soon as i can.

[tsaarni]

Thank you @Sefiris, I assigned this issue to you.