commitMessageExtra + matchDepTypes not applied when there are 2 types of updates for the same dep #42449
Replies: 1 comment 4 replies
-
|
I think the issue is that Try switching to If you still only get one update, check the logs for "group" behavior - Renovate may be collapsing them. In that case, |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
How are you running Renovate?
A Mend.io-hosted app
Which platform you running Renovate on?
GitHub.com
Which version of Renovate are you using?
43.102.11
Please tell us more about your question or problem
Tip
While writing this I've realized how to achieve what I wanted by using
"matchUpdateTypes": ["major"]instead of"matchDepTypes": ["peerDependencies"], but I've decided to create this issue nonetheless, because I find the behavior confusing.renovate.json{ "$schema": "https://docs.renovatebot.com/renovate-schema.json", "extends": [ "config:recommended" ], "semanticCommits": "enabled", "separateMajorMinor": true, "packageRules": [ { "matchPackageNames": ["typescript"], "matchDepTypes": ["peerDependencies"], "commitMessageAction": "Support", "commitMessageTopic": "{{depName}}", "commitMessageExtra": "{{prettyNewMajor}}", "semanticCommitType": "feat", "semanticCommitScope": null, "commitMessageLowerCase": "never" } ] }package.json{ "peerDependencies": { "typescript": "^5" }, "devDependencies": { "typescript": "~5.0.4" } }Outcome
Expected:
feat: Support typescript v6Actual:
feat: Support typescript to v6.0.2Notes
The same commit that widens the peer dependencies, also updates the dev dependencies, as expected 👍
Unfortunately, that seems to somehow result in JUST the
commitMessageExtranot applying — every other part of the config is respected AFAICT.If I replace
matchDepTypeswithmatchUpdateTypes: ['major']then I get the expected result. I'm guessing that with the former there are 2 updates battling it out for the commit message, but it's confusing why the rest of the message parts are applied correctly, e.g.commitMessageActionandsemanticCommitScope.matchUpdateTypes(correct)matchDepTypes(incorrect)Logs (if relevant)
I don't see any granular logs about applying the
packageRulesor computing the commit messages.Beta Was this translation helpful? Give feedback.
All reactions