Keyboard shortcut "play" conflicts with macOS default shortcuts in Firefox

[henrebotha]

macOS has a built-in shortcut for Ctrl-Enter (it opens the context menu). When using Strudel in Firefox specifically, attempting to use Ctrl-Enter to play/refresh doesn't work; it just opens the context menu. This does not happen in Chrome.

The default shortcut needs to change under macOS, or the way that shortcuts are handled needs to change so that this bug doesn't happen in Firefox.

I would also argue that the shortcuts need to be different in macOS entirely. Cmd-Enter is very commonly interpreted by IDEs as "run the thing under the cursor", and there is a general pattern of using Cmd on macOS for the things you'd use Ctrl for on Windows.

[yaxu]

Does option-enter work?

[henrebotha]

Does option-enter work?

It appears to, yeah.

[yaxu]

You can also switch off the annoying context menu in your os settings.

[yaxu]

It seems that in the key-bindings, we could specify mod- rather than ctrl-:

You can use Mod- as a shorthand for Cmd- on Mac and Ctrl- on other platforms. So Mod-b is Ctrl-b on Linux but Cmd-b on macOS.
https://codemirror.net/docs/ref/

I'm not a mac person but that seems like a good thing to do? Disruptive in the short term..

[henrebotha]

You can also switch off the annoying context menu in your os settings.

Yeah I ended up doing that, I've got it as Ctrl-Alt-Enter now.

It seems that in the key-bindings, we could specify mod- rather than ctrl- […] I'm not a mac person but that seems like a good thing to do? Disruptive in the short term..

Oh it makes a lot of sense that CM would provide that shortcut. Yeah that probably would make some amount of sense, though I agree that it could end up being quite disruptive for a time and would probably raise other conflicts similar to the one I reported here.

Ultimately I think the real responsibility here lies with CM, and I don't know if they offer a way to handle things under Firefox such that it behaves the same as Chrome. My intuitive suggestion would be to adjust the "play" shortcut to use Cmd-Enter (or to add this as an alternative) and leave it at that.

I also didn't see Alt-Enter (aka Option-Enter) documented anywhere, so maybe the real solution is just to document that as an alternative.