Empty string

[Tolik-Trek]

Version	Platform	Topic
v1.22.0	MacOS

error: Empty string: ""," "}
VOLUME_SET_ID	TEXT	128,{""," "} 

The previous version didn't throw this error. And the string here shouldn't be empty, because the length and padding are specified.

 STRUCT _sCDFS_PRIMARY_VOLUME_DESCRIPTOR
.TYPE:				BYTE	1
.IDENTIFIER:			TEXT	5,{"CD001"}					
.VERSION			BYTE	1						
.Unused_0			BYTE	0						
.SYS_ID				TEXT	32,{"Sprinter 2000, BIOS > 3.06"," "}		
.VOLUME_LABEL			TEXT	32,{"CDFS VOLUME"," "}				
.Unused_Block_0			BLOCK	8,0						
.VOLUME_SPACE_SIZE		DWORD	0
.VOLUME_SIZE_be			DWORD	0
.Unused_Block_1			BLOCK	32,0						
.VOLUME_SET_SIZE		WORD	1						
.VOLUME_SET_SIZE_be		WORD	#0100						
.VOL_SEQUENCE_NUMBER		WORD	1						
.VOL_SEQUENCE_NUMBER_be		WORD	#0100						
.LOGICAL_BLCOK_SIZE		WORD	#800						
.LOGICAL_BLCOK_SIZE_be		WORD	8						
.PATH_TABLE_SIZE		DWORD	0						
.PATH_TABLE_SIZE_be		DWORD	0						
.LBA_TYPE_L_PATH_TABLE		WORD	0						
.LBA_OPTIONAL_TYPE_L_PATH_TBL	WORD	0						
.LBA_TYPE_M_PATH_TABLE		WORD	0						
.LBA_OPTIONAL_TYPE_M_PATH_TBL	WORD	0						
.ROOT_DIR_ENTRY			BLOCK	34,0						
.VOLUME_SET_ID			TEXT	128,{""," "}				; error: Empty string: ""," "}	
.PUBLISHER_SET_ID		TEXT	128,{""," "}				; error: Empty string: ""," "}	
.DATA_PREPARER_ID		TEXT	128,{""," "}				; error: Empty string: ""," "}	
.APPLICATION_ID			TEXT	128,{""," "}				; error: Empty string: ""," "}	
.COPYRIGHT_ROOT_FILE_NAME	TEXT	37,{""," "}				; error: Empty string: ""," "}	
.ABSTRACT_ROOT_FILE_NAME	TEXT	37,{""," "}				; error: Empty string: ""," "}	
.BIBLIOGRAPHIC_ROOT_FILE_NAME	TEXT	37,{""," "}			; error: Empty string: ""," "}		
.VOL_CREATION			_sCDFS_DATE_TIME					
.VOL_MODIFICATION		_sCDFS_DATE_TIME					
.VOL_EXPIRATION			_sCDFS_DATE_TIME					
.VOL_EFFECTIVE			_sCDFS_DATE_TIME					
.FILE_STRUCTURE_VERSION		BYTE	1						
.Unused_1			BYTE	0						
.APPLICATION_USED		TEXT	512,{"Sprinter 2000. Tolik_Trek@SprinterTeam"}	
.RESERVED			BLOCK	653,0						
 ENDS

[ped7g]

I will look into it more deeply later, but the empty string is about that "" literal.

And I think the message is "just" warning, so you are probably using --syntax=w to report warnings as errors.
Unfortunately it's not id-warning, so you can't suppress it.

Any particular reason why you need "" there, can't you use VOLUME_SET_ID TEXT 128,{" "} ?

I'm not sure what would be the fix, I guess changing it to id-warning so it can be suppressed where you use "" intentionally? (or turned off completely by OPT -Wno-<id> , if you are not interested about empty string warnings)

[Tolik-Trek]

Theoretically, it's not an empty string. In STRUCT, we specify a string + placeholder, and the resulting string is not empty. This is how it worked before, but in this version it works differently, so I thought it was a bug)))

[ped7g]

nah, it's "improved" warning about empty string literals. So if I will turn it into id-warning, you can OPT -Wno-<someid> to suppress them for your project - is this OK for you as final "solution"?

[Tolik-Trek]

👍