Skip to content

SLD values for EQU could provide the explicit page num too? #326

@ped7g

Description

@ped7g

sjasmplus/sjasm/parser.cpp

Lines 797 to 801 in 1fbffea

} else if (IsSldExportActive()) {
// SLD (Source Level Debugging) tracing-data logging
WriteToSldFile(IsEQU ? -1 : label->page, val, IsEQU ? 'D' : 'F', tp); //version 0
WriteToSldFile(IsEQU ? -1 : label->page, val, 'L', ExportLabelToSld(ttp, label)); //version 1
}

I think the IsEQU ? -1 can be IsEQU ? equPageNum, so it will export also the explicit EQU page number? Can't think of any reason why this is left out currently, if this was somehow intentional or it just happened over time as features were added?

Also if the equPageNum is wanted in SLD, would just label->page produce the same result then? Verify.
EDIT: no, the EQU have memory-mapped deducted page value, unless explicit equ page was given, so label->page is not usually -1 (undefined).

conclusion: still, if explicit page number is given, maybe it can be exported to SLD?

Metadata

Metadata

Assignees

Labels

RFCRequest For Comments (opinions)enhancement

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions