[PWGEM,PWGEM-36] PM: Fix bug in MCUtilitits isMotherPDG and change …#15876
Merged
mhemmer-cern merged 1 commit intoAliceO2Group:masterfrom Apr 20, 2026
Merged
[PWGEM,PWGEM-36] PM: Fix bug in MCUtilitits isMotherPDG and change …#15876mhemmer-cern merged 1 commit intoAliceO2Group:masterfrom
isMotherPDG and change …#15876mhemmer-cern merged 1 commit intoAliceO2Group:masterfrom
Conversation
…some histograms in photon reso task - Fix bug in `isMotherPDG` from `MCUtilities.h` where the function returend true when the mother was NOT the searched particle type, instead of returning true when it IS the searched particle type. - Add `getMotherIndexFromChain` inside `MCUtilities.h` which is similar to `isMotherPDG` but instead of returning true or false it returns the global index of the mother mcparticle. - Change eta and phi resolution histograms to use true vs (true - rec) / true instead of rec vs true. - Change Pi0EtaToGamma task for EMCal to use the MinCluster tables from `DataModel/GammaTablesRedux.h`.
mhemmer-cern
requested review from
alibuild,
dsekihat,
hscheid and
jokonig
as code owners
|
O2 linter results: ❌ 4 errors, |
alibuild
approved these changes
Apr 20, 2026
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…some histograms in photon reso task
Fix bug in
isMotherPDGfromMCUtilities.hwhere the function returend true when the mother was NOT the searched particle type, instead of returning true when it IS the searched particle type.Add
getMotherIndexFromChaininsideMCUtilities.hwhich is similar toisMotherPDGbut instead of returning true or false it returns the global index of the mother mcparticle.Change eta and phi resolution histograms to use true vs (true - rec) / true instead of rec vs true.
Add extra histograms to distinguish clusters where the main contributor is a leg from a photon between those were both legs are inside the cluster and those were only one is inside the cluster
Change Pi0EtaToGamma task for EMCal to use the MinCluster tables from
DataModel/GammaTablesRedux.h.