Switch istioctl to be installed through the Azure Linux package feed#613
Open
ComradeCow wants to merge 3 commits intomasterfrom
Open
Switch istioctl to be installed through the Azure Linux package feed#613ComradeCow wants to merge 3 commits intomasterfrom
ComradeCow wants to merge 3 commits intomasterfrom
Conversation
Contributor
|
Image size with this change is base: 6089MB, tools: 9658MB. |
| && /opt/ansible/bin/python -m pip install -r /usr/share/ansible/collections/ansible_collections/azure/azcollection/requirements.txt | ||
|
|
||
|
|
||
| # Install specific version of Istio from GitHub releases |
Contributor
There was a problem hiding this comment.
if this is going to be shipped from mariner linux, we should also remove istioctl auto-update chore PR in the github action. Rootless docker kit chore is required for vscode.
Contributor
|
Image size with this change is base: 6089MB, tools: 9658MB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently install
istioctlfrom the official Github releases while building the base docker image. This was done to ensure the version of istio was up-to-date with the latest.This PR switches the install location to come from the Azure Linux package feed. Per discussions with the team publishing the packages, they maintain a 5-day SLA for republishing newly released versions to the feed. The Azure Linux package feed version is built to ensure compliance with our internal security scanning tools.