Remove shimmer animation from freebuff waiting room Wait time#523
Merged
Remove shimmer animation from freebuff waiting room Wait time#523
Conversation
Contributor
Greptile SummaryThis PR removes the
Confidence Score: 5/5Safe to merge — minimal, isolated UI change with no logic impact. Single-file, purely cosmetic change that removes an animation wrapper. The underlying conditional logic is untouched, the import is correctly preserved because ShimmerText is still used elsewhere in the same file, and there are no edge cases to worry about. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[WaitingRoomScreen renders] --> B{session.status}
B -- waiting --> C[Show Position / Wait / Elapsed rows]
C --> D{session.position === 1?}
D -- Yes --> E["Render 'any moment now' (plain text)"]
D -- No --> F["Render formatWait(session.estimatedWaitMs) (plain text)"]
B -- joining --> G["ShimmerText: 'Joining the waiting room…'"]
B -- disabled --> H[Show disabled message]
Reviews (1): Last reviewed commit: "Remove shimmer animation from freebuff w..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unwraps the
Waittime value in the freebuff waiting room fromShimmerTextso it renders as plain static text. The shimmering wait estimate read as flickering noise next to the staticPositionandElapsedrows; the other shimmer (the "Joining the waiting room…" placeholder) is preserved.