Open
Conversation
tal5
suggested changes
Apr 20, 2026
| // --> | ||
| tagProcessor.registerMechanism("forum_post_tags", false, (object, mechanism) -> { | ||
| if (!(object.getChannel() instanceof ThreadChannel threadChannel)) { | ||
| mechanism.echoError("Cannot adjust 'forum_post_tags' tag: this channel is not a forum post."); |
Member
There was a problem hiding this comment.
mechanism*, but the error already automatically has the whole Error while adjusting mechanism 'X' on 'OBJECT': in it, you only really need the actual error message.
| ListTag input = mechanism.valueAsType(ListTag.class); | ||
| int size; | ||
| if (input.size() > 5) { | ||
| mechanism.echoError("The 'DiscordChannelTag.forum_post_tags' mechanism has a maximum input of 5 tag ids."); |
Member
There was a problem hiding this comment.
Same here, the mechanism name and everything is already automatically in the error message (or should be at least).
| // <--[mechanism] | ||
| // @object DiscordChannelTag | ||
| // @name forum_post_tags | ||
| // @input ListTag |
Member
There was a problem hiding this comment.
All of these would be ListTag(Number) I believe?
| } | ||
| Collection<ForumTagSnowflake> forumTags = new ArrayList<>(size); | ||
| for (int i = 0; i < size; i++) { | ||
| forumTags.add(ForumTagSnowflake.fromId(input.get(i))); |
Member
There was a problem hiding this comment.
Can check if there's precedence one way or the other in the rest of dDiscordBot, but might better if we handle the long parsing ourselves (so that invalid input is a nice Denizen error and not an exception).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested at https://discord.com/channels/315163488085475337/1443702893097255012