Skip to content

Enhanced payload decoding and format support#408

Open
ladsmund wants to merge 6 commits intomainfrom
feature/firnapp_payload
Open

Enhanced payload decoding and format support#408
ladsmund wants to merge 6 commits intomainfrom
feature/firnapp_payload

Conversation

@ladsmund
Copy link
Copy Markdown
Collaborator

  • Added new payload types (b, w, c) to payload_types.csv and updated associated formats in payload_formats.csv.
  • Implemented decoding logic for new types (b, w, c) in decode function.
  • Refactored decode_payload by introducing better modularity and default path handling for payload formats.
  • Improved logging and streamlined docstrings for clarity.
  • Fixed argument naming inconsistencies and standardized defaults.

TODO: This branch override existing format numbers (25 and 43). Correct the format type numbers to non occupied values to revert to the previous formats before merging.

- Added new payload types (`b`, `w`, `c`) to `payload_types.csv` and updated associated formats in `payload_formats.csv`.
- Implemented decoding logic for new types (`b`, `w`, `c`) in `decode` function.
- Refactored `decode_payload` by introducing better modularity and default path handling for payload formats.
- Improved logging and streamlined docstrings for clarity.
- Fixed argument naming inconsistencies and standardized defaults.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

Dataset Comparison Report

✅ Datasets match perfectly!

No differences have been found between the datasets produced using the PR branch and the main branch.
⚠️ This report is generated from a small subset of test data that does not reflect all scenarios. Please check using more input data if you suspect changes to the output data have occurred.

Copy link
Copy Markdown
Collaborator Author

@ladsmund ladsmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch override existing format numbers (25 and 43). Correct the format type numbers to non occupied values to revert to the previous formats before merging.

Comment thread src/pypromice/resources/payload_formats.csv Outdated
hetja1430 and others added 4 commits March 16, 2026 14:07
@ladsmund ladsmund changed the title Draft: Enhanced payload decoding and format support Enhanced payload decoding and format support Mar 16, 2026
…ine imports

- Removed redundant import for `DEFAULT_PAYLOAD_FORMATS_PATH`.
- Added fallback logic to handle missing payload formats path dynamically.
- Updated argument parser to set `None` as default for payload format path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants