Draft
Conversation
There are a few things in the Linux setup script that cause the scripts to fail on Ubuntu 24.04. Mainly, some package names have changed, so attempting to install them fails. This commit renames the `docker` package to `docker-ce` and removes a bunch of other packages. These were all opinionated software choices added to the scripts years ago, some of which are now outdated or not useful at Khan Academy. This also removes the setup_clock() function. It wasn't doing anything anyway, since the location of the ntp.conf file has changed since it was written, and it's also not necessary. Issue: none Test plan: - Run `make` on my Ubuntu 24.04 development machine that was already set up for Khan development. - TODO: Run on a new Ubuntu 24.04 install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There are a few things in the Linux setup script that cause the scripts
to fail on Ubuntu 24.04. Mainly, some package names have changed, so
attempting to install them fails.
This commit renames the
dockerpackage todocker-ceand removes abunch of other packages. These were all opinionated software choices
added to the scripts years ago, some of which are now outdated or not
useful at Khan Academy.
This also removes the setup_clock() function. It wasn't doing anything
anyway, since the location of the ntp.conf file has changed since it was
written, and it's also not necessary.
Issue: none
Test plan:
makeon my Ubuntu 24.04 development machine that was already setup for Khan development.