Draft
Conversation
kevinb-khan
commented
Apr 15, 2026
Comment on lines
+31
to
+43
| frontend-only: | ||
| ./git_sync.sh | ||
| rm -f ~/.profile-generated.khan && touch ~/.profile-generated.khan | ||
| if [ `uname -s` = Darwin ]; then \ | ||
| ./mac-setup.sh --frontend-only; \ | ||
| fi | ||
| ./setup.sh --frontend-only | ||
| @echo "*** YOU MUST REBOOT **IF** this was ***" | ||
| @echo "*** the first time you've setup ***" | ||
| @echo "*** khan-dotfiles (i.e. if you are ***" | ||
| @echo "*** onboarding) ***" | ||
| @echo "*** (Reboot is required for browser ***" | ||
| @echo "*** to pickup CA for khanacademy.dev) ***" |
Author
There was a problem hiding this comment.
@jonahgoldsaito this is okay for now. I think we'll want to figure out a way to dedupe the code a bit before landing this. I'll do some thinking on how to do that.
There was a problem hiding this comment.
Yeah, I noticed the annoying duplication.
TBH I didn't push to hard shaming it with DRY principles 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The purpose of this flag is to make it so that non-engineers who want to vibe code prototypes within webapp don't have to install as much stuff when setting things up. The flag only has any effect on MacOS machines because it's assumed that all designers are using MacOS.
Issue: FEI-7369
Test plan: