Skip to content

Use segment group name as filename in volview.zip#860

Merged
PaulHax merged 3 commits intomainfrom
segment-group-zip-names-slicer-io
Apr 16, 2026
Merged

Use segment group name as filename in volview.zip#860
PaulHax merged 3 commits intomainfrom
segment-group-zip-names-slicer-io

Conversation

@PaulHax
Copy link
Copy Markdown
Collaborator

@PaulHax PaulHax commented Apr 13, 2026

  • Use the segment group's display name (sanitized) as the filename when exporting segment groups or saving session ZIPs, instead of the internal ID
  • Store segment-group archives under a segmentations/ directory in session ZIPs instead of lablemaps/
  • Improve itk-wasm pipeline error messages: wrap raw numeric pointers and empty crashes with human-readable text to surface stderr for non-crash pipeline failures

@PaulHax PaulHax force-pushed the segment-group-zip-names-slicer-io branch from 4db372a to 02396a8 Compare April 13, 2026 19:01
@PaulHax PaulHax changed the title Sanitize segment group archive paths Use segment group name as filname in volview.zip Apr 13, 2026
@PaulHax PaulHax force-pushed the segment-group-zip-names-slicer-io branch 2 times, most recently from 855d94b to ac3b740 Compare April 13, 2026 21:05
@PaulHax PaulHax changed the title Use segment group name as filname in volview.zip Use segment group name as filename in volview.zip Apr 13, 2026
@PaulHax PaulHax force-pushed the segment-group-zip-names-slicer-io branch from caac513 to 85d0f7d Compare April 13, 2026 21:45
@PaulHax PaulHax marked this pull request as ready for review April 13, 2026 21:52
@PaulHax PaulHax requested a review from arhowe00 April 13, 2026 21:54
Base automatically changed from slicer-io to main April 16, 2026 20:24
PaulHax added 3 commits April 16, 2026 16:25
When zipping up session.volview.zip files.
itk-wasm WASM modules throw raw numeric pointers when they crash,
and stderr output only goes to console.error, not the thrown error.
This made load failures show meaningless numbers or empty messages.

- Wrap readDicomTags errors in handleDicomFile and handleDicomStream
  with human-readable messages, preserving originals as cause
- Check runTask returnValue/stderr for non-crash pipeline failures
- Add getErrorDetail utility for extracting meaningful error messages
@PaulHax PaulHax force-pushed the segment-group-zip-names-slicer-io branch from e22c351 to badead6 Compare April 16, 2026 20:26
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 16, 2026

Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit badead6
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/69e14601b61dd50008638097
😎 Deploy Preview https://deploy-preview-860--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PaulHax PaulHax added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 5b2b4b9 Apr 16, 2026
7 checks passed
@PaulHax PaulHax deleted the segment-group-zip-names-slicer-io branch April 16, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant