add support for predefinedtilegrid in split_area #883#886
Open
VincentVerelst wants to merge 16 commits intomasterfrom
Open
add support for predefinedtilegrid in split_area #883#886VincentVerelst wants to merge 16 commits intomasterfrom
VincentVerelst wants to merge 16 commits intomasterfrom
Conversation
HansVRP
reviewed
Apr 3, 2026
Contributor
HansVRP
left a comment
There was a problem hiding this comment.
Some initial comments and questions
… crs. SizebasedTileGrid doesn't follow a pre-defined grid centered at 0,0 but rather uses the AOI bottom left as anchor point #883
Collaborator
Author
|
@HansVRP , except for addressing your comments, one big change: there is now a standardized reprojecting happening to the CRS of the tile grid that is being used for splitting. To re-iterate what will be exposes to the public API: the
Advanced users can always define their own splitting method by defining a subclass of |
Contributor
|
will look into the update; thanks. can you also include a usecase example in: https://github.com/Open-EO/openeo-python-client/blob/master/docs/cookbook/job_manager.rst ? |
…er than 500x500 tiles #883
HansVRP
approved these changes
Apr 15, 2026
|
|
||
| # TODO: provide west, south, east, north, crs as @properties? Read-only or read-write? | ||
|
|
||
| def as_polygon(self) -> shapely.geometry.Polygon: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to expose the
split_areafunction to users. Users can provide an AOI, which can be split in different ways:projectionandtile_size: splits the AOI up in square tilesPredefinedTileGrid(can also be ageopandas.GeoDataFrame), which splits the AOI according to that gridTileGridInterface: splits the AOI according to their custom classThe function returns the split AOI as a
geopandas.GeoDataFrame