[clientpython] feat(pyoaev): add multi-tenancy (#205)#208
Draft
Megafredo wants to merge 1 commit intorelease/currentfrom
Draft
[clientpython] feat(pyoaev): add multi-tenancy (#205)#208Megafredo wants to merge 1 commit intorelease/currentfrom
Megafredo wants to merge 1 commit intorelease/currentfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #208 +/- ##
==================================================
Coverage ? 70.63%
==================================================
Files ? 58
Lines ? 2350
Branches ? 0
==================================================
Hits ? 1660
Misses ? 690
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
15bc188 to
9e3ed3f
Compare
Kakudou
requested changes
Apr 16, 2026
Member
Kakudou
left a comment
There was a problem hiding this comment.
LGTM, everything seem in place, thanks. 🔥
If you can add some tests for that it would be perfects. 🤘
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
1. Client-side implementation using Python (
pyoaev)1.1 Managing the
tenant_idin the configuration (settings_loader.py)tenant_idfield toConfigLoaderOAEVtenant_id: UUIDtenant_id: UUID | Nonedefault=None,for now and replace it withdefault="2cffad3a-0001-4078-b0e2-ef74274022c3",once the migration is officially live1.2 Managing the
tenant_idin the pyoaev (client.py)tenant_id: Optional[UUID]to the client constructor_build_url()to support:base_urlandpathnormalizationurl_legacyif no tenant_id existsurl_tenantif tenant_id exists1.3 Managing the
tenant_idin the pyoaev (helper.py)OpenAEVInjectorHelpertenant_idfrom the config and sendOpenAEV1.4 Managing the
tenant_idin the pyoaev (utils.py)tenant_idtriggered duringPingAlivetenant_idwhen stoppingPingAlive1.5 Managing the
tenant_idin daemons (base_daemon.py)__get_default_api_clientwith the tenant_id2. Tests
Related issues
Checklist
Further comments