fix(protocol-designer): Fix misaligned "Edit labware" overlay in OffDeckDetails#18969
Merged
SyntaxColoring merged 3 commits intoedgefrom Jul 21, 2025
Merged
fix(protocol-designer): Fix misaligned "Edit labware" overlay in OffDeckDetails#18969SyntaxColoring merged 3 commits intoedgefrom
SyntaxColoring merged 3 commits intoedgefrom
Conversation
fbcaad4 to
6afc23d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18969 +/- ##
=======================================
Coverage 23.98% 23.99%
=======================================
Files 3354 3354
Lines 294303 294305 +2
Branches 31022 31015 -7
=======================================
+ Hits 70602 70604 +2
Misses 223680 223680
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cornerOffsetFromSlot.Test Plan and Hands on Testing
cornerOffsetFromSlotbug fixHere is a custom labware definition (in schema 2) that intentionally overflows 10 mm beyonds the bounds of a deck slot. chubby_well_plate.json.zip. The 96 wells are clustered in the front-left corner because I copy-pasted them and was too lazy to update their coordinates.
Before:
After:
Labware schema 3 support
Protocol Designer doesn't yet support labware schema 3 well enough in general for us to import a real schema-3 definition here and test it, unfortunately. But this is an easy change following a previously-established pattern, so I'm comfortable with it.
Review requests
None in particular.
Risk assessment
Low.