Skip to content

fix(protocol-designer): Fix misaligned "Edit labware" overlay in OffDeckDetails#18969

Merged
SyntaxColoring merged 3 commits intoedgefrom
fix_offdeckdetails
Jul 21, 2025
Merged

fix(protocol-designer): Fix misaligned "Edit labware" overlay in OffDeckDetails#18969
SyntaxColoring merged 3 commits intoedgefrom
fix_offdeckdetails

Conversation

@SyntaxColoring
Copy link
Copy Markdown
Contributor

@SyntaxColoring SyntaxColoring commented Jul 18, 2025

Overview

  1. Fix a bug where the "Edit labware" overlay would be misaligned if the labware had a nonzero cornerOffsetFromSlot.
  2. Prepare this component for labware schema 3, which is a step towards EXEC-1551.

Test Plan and Hands on Testing

cornerOffsetFromSlot bug fix

Here is a custom labware definition (in schema 2) that intentionally overflows 10 mm beyonds the bounds of a deck slot. chubby_well_plate.json.zip. The 96 wells are clustered in the front-left corner because I copy-pasted them and was too lazy to update their coordinates.

  1. Go to "Starting deck" in the protocol timeline
  2. Go to the "Off-deck" tab
  3. Add a new labware
  4. Import the custom labware above and select it
  5. Ignore the broken labware render as soon as you do that, which is a different component and a different problem
  6. View the "Off-deck" tab again, now with the newly-added labware

Before:

Screenshot 2025-07-18 at 2 08 48 PM

After:

Screenshot 2025-07-18 at 2 10 10 PM

Labware schema 3 support

Protocol Designer doesn't yet support labware schema 3 well enough in general for us to import a real schema-3 definition here and test it, unfortunately. But this is an easy change following a previously-established pattern, so I'm comfortable with it.

Review requests

None in particular.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from jerader July 18, 2025 19:20
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner July 18, 2025 19:20
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.99%. Comparing base (203eeb4) to head (6afc23d).
Report is 11 commits behind head on edge.

Files with missing lines Patch % Lines
shared-data/js/helpers/positionMath.ts 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18969   +/-   ##
=======================================
  Coverage   23.98%   23.99%           
=======================================
  Files        3354     3354           
  Lines      294303   294305    +2     
  Branches    31022    31015    -7     
=======================================
+ Hits        70602    70604    +2     
  Misses     223680   223680           
  Partials       21       21           
Flag Coverage Δ
protocol-designer 18.98% <90.00%> (+<0.01%) ⬆️
step-generation 5.32% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ner/src/pages/Designer/OffDeck/OffDeckControls.tsx 68.47% <100.00%> (+1.45%) ⬆️
...gner/src/pages/Designer/OffDeck/OffDeckDetails.tsx 67.70% <100.00%> (-0.40%) ⬇️
shared-data/js/helpers/positionMath.ts 12.79% <75.00%> (+1.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SyntaxColoring SyntaxColoring merged commit c7c6032 into edge Jul 21, 2025
66 of 67 checks passed
@SyntaxColoring SyntaxColoring deleted the fix_offdeckdetails branch July 21, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants