Skip to content

fix(api,shared-data): disables TOF sensor labware detection on the hopper tower + generate PVT baseline.#18977

Merged
vegano1 merged 23 commits intoedgefrom
flex-stacker-disable-tof-z
Jul 22, 2025
Merged

fix(api,shared-data): disables TOF sensor labware detection on the hopper tower + generate PVT baseline.#18977
vegano1 merged 23 commits intoedgefrom
flex-stacker-disable-tof-z

Conversation

@vegano1
Copy link
Copy Markdown
Contributor

@vegano1 vegano1 commented Jul 21, 2025

Overview

We are seeing inconsistencies between DVT and PVT TOF sensor measurements in the Z axis. Let's disable the TOF sensor labware detection for the stacker tower (Z Axis) in order to move forward with QA/ABR testing process while we debug in Shenzhen what is happening. This pull request disables the TOF Sensor on the Z axis, and generates a new baseline using PVT stacker data gathered in Shenzhen.

Test Plan and Hands on Testing

  • Test stackers to make sure you can detect tipracks, and pcr plates on the X-retracted position.

Changelog

  • Don't drop Labware on dispense, this should be fixed on pvt stackers.
  • Disables the TOF sensor on the Z
  • Generates new baseline using PVT histogram measurements
  • Expands the "validate_baseline" functionality of the tof_analysis.py tool to print out and plot when labware is detected.

Review requests

Risk assessment

@vegano1 vegano1 requested review from a team as code owners July 21, 2025 02:13
@vegano1 vegano1 requested review from CaseyBatten and ncdiehl11 and removed request for a team July 21, 2025 02:13
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.21%. Comparing base (5273183) to head (1a3ac1c).
Report is 10 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18977      +/-   ##
==========================================
+ Coverage   23.98%   25.21%   +1.22%     
==========================================
  Files        3354     3357       +3     
  Lines      294283   294813     +530     
  Branches    31022    31079      +57     
==========================================
+ Hits        70588    74336    +3748     
+ Misses     223674   220450    -3224     
- Partials       21       27       +6     
Flag Coverage Δ
protocol-designer 18.96% <ø> (-0.01%) ⬇️
step-generation 5.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 103 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In person review of tool and changes, all looks good for SHZN

@vegano1 vegano1 merged commit 1514772 into edge Jul 22, 2025
74 checks passed
@vegano1 vegano1 deleted the flex-stacker-disable-tof-z branch July 22, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants