Conversation
ignore stallguard thresholds higher than 2 in the stallguard test change stallguard threshold test format to decouple stall detection and test result add debug logging for the labware detection routine
…d tof_analysis.py
…rons/opentrons into pvt-diagnostics-test-fixes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18977 +/- ##
==========================================
+ Coverage 23.98% 25.21% +1.22%
==========================================
Files 3354 3357 +3
Lines 294283 294813 +530
Branches 31022 31079 +57
==========================================
+ Hits 70588 74336 +3748
+ Misses 223674 220450 -3224
- Partials 21 27 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CaseyBatten
approved these changes
Jul 21, 2025
Contributor
CaseyBatten
left a comment
There was a problem hiding this comment.
In person review of tool and changes, all looks good for SHZN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We are seeing inconsistencies between DVT and PVT TOF sensor measurements in the Z axis. Let's disable the TOF sensor labware detection for the stacker tower (Z Axis) in order to move forward with QA/ABR testing process while we debug in Shenzhen what is happening. This pull request disables the TOF Sensor on the Z axis, and generates a new baseline using PVT stacker data gathered in Shenzhen.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment