refactor(js): Minor cleanups to the global scope#19573
Closed
SyntaxColoring wants to merge 2 commits intoedgefrom
Closed
refactor(js): Minor cleanups to the global scope#19573SyntaxColoring wants to merge 2 commits intoedgefrom
SyntaxColoring wants to merge 2 commits intoedgefrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #19573 +/- ##
==========================================
+ Coverage 23.73% 23.97% +0.24%
==========================================
Files 3419 3431 +12
Lines 302359 303362 +1003
Branches 39474 39592 +118
==========================================
+ Hits 71766 72735 +969
- Misses 230576 230611 +35
+ Partials 17 16 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Alright, I understand TypeScript worse than I thought and can't figure out those errors. Might come back to this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Minor improvements to our Vite config and TypeScript declarations.
Changelog
globalwithglobalThis. (As I understand it,globalis a historical Node-ism, andglobalThisis the modern standard cross-environment replacement.) With this PR, our source code just spells outglobalThisdirectly, and we can delete that bit of Vite config. There's a lint rule to prevent us from usingglobalin the future.// @ts-expect-errors. The trick seems to be that if the .d.ts file is a module, you gotta wrap it withdeclare global {}, and if it's not a module, you gotta not. 🤷Test Plan and Hands on Testing
Just CI.
Review requests
None in particular.
Risk assessment
Low.