fix(api): Ensure parent to lid stack is valid source for move lid action#19574
Merged
CaseyBatten merged 3 commits intochore_release-8.7.0from Sep 16, 2025
Merged
Conversation
sfoster1
approved these changes
Sep 16, 2025
Member
sfoster1
left a comment
There was a problem hiding this comment.
Nice, looks good to me. I think we can integrate the labware display name into the error message a little more nicely
| lid_id = lid.id | ||
| else: | ||
| raise ValueError( | ||
| f"Cannot move a lid off of a labware with no lid. {labware.get_display_name()}" |
Member
There was a problem hiding this comment.
Suggested change
| f"Cannot move a lid off of a labware with no lid. {labware.get_display_name()}" | |
| f"Cannot move a lid off of {labware.get_display_name()} because it has no lid." |
?
Contributor
Author
There was a problem hiding this comment.
Oh yeah absolutely, good catch. Thats definitely a left over message format from debugging on my end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Partially covers RESC-498
In testing the protocol related to the issue in the ticket mentioned, it was discovered that if a user supplies the parent labware to a dynamically allocated lid stack as a source for a
move_lidcommand then they will get an error. Providing labware as a source for a lid stack is something that our API allows, but in the case of dynamically created stacks it was not working. This PR fixes that by allowing themove_lid logicto identify lid stacks by their relative parent as an extension of their base behavior.Test Plan and Hands on Testing
Changelog
Update
move_lidfunction to correctly identify child lid stacks by a given parent labwareReview requests
Risk assessment
Med/Low - Fixes an existing bug regarding acceptable fields for the
move_lidcommand