chore(protocol-visualization): scaffold package, tests, and CI workflow#21087
Merged
chore(protocol-visualization): scaffold package, tests, and CI workflow#21087
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #21087 +/- ##
==========================================
+ Coverage 56.62% 57.72% +1.09%
==========================================
Files 3992 3956 -36
Lines 330706 324094 -6612
Branches 46678 46113 -565
==========================================
- Hits 187260 187079 -181
+ Misses 143225 136796 -6429
+ Partials 221 219 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jerader
approved these changes
Mar 23, 2026
Collaborator
jerader
left a comment
jerader
left a comment
There was a problem hiding this comment.
seems reasonable, thanks! these all work at the root of the monorepo:
make -C protocol-visualization lint
make -C protocol-visualization check-ts
make -C protocol-visualization test
make -C protocol-visualization lib
looks like ci is failing though. feel free to merge after it passes.
sanni-t
reviewed
Mar 23, 2026
Comment on lines
+7
to
+10
| "/protocol-designer/*": ["./protocol-designer/src/*"], | ||
| "@opentrons/components": ["./components/src/index.ts"], | ||
| "@opentrons/shared-data": ["./shared-data/js/index.ts"], | ||
| "@opentrons/step-generation": ["./step-generation/src/index.ts"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds
@opentrons/protocol-visualization: stub exports,link:deps on components, shared-data, step-generation, Vitest (including workspace resolution smoke test), Vite/tsconfig, in-repo PLAN / CONVENTIONS / README. New workflowprotocol-visualization-ci.tsconfigpaths(+ tsconfig-eslint) fix types for@opentrons/componentswithout a priorcomponents/libbuild. No changes under app/, components/, or step-generation/ source.Test Plan and Hands on Testing
Changelog
Risk assessment