chore: "fix" lint-js

[sfoster1]

If you do make setup-js and then make lint-js, you get one million failures from the typescript-eslint untyped-argument checker. However, if you run make build-ts first (aka run tsc) then you don't (which is why more frequent js devs don't get these errors). This is probably because we use divergent configurations for eslint's typescript plugin invocations of tsc and our normal invocations of tsc. This is very complicated and I think would be very annoying to fix, so we can just add a makefile dependency so you always build first.

Test Plan and Hands on Testing

• run teardown, then setup, then lint-js. it shouldn't fail

Review requests

• hurt your soul too much?

Risk assessment

• none (doesn't even break CI, since the check workflow in CI happens to run make check-js first, which runs tsc)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.85%. Comparing base (eafd5ff) to head (ac12a31).
⚠️ Report is 4 commits behind head on chore_release-9.0.0.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           chore_release-9.0.0   #21106   +/-   ##
====================================================
  Coverage                55.85%   55.85%           
====================================================
  Files                     3924     3924           
  Lines                   328691   328712   +21     
  Branches                 48349    48358    +9     
====================================================
+ Hits                    183593   183615   +22     
+ Misses                  144881   144880    -1     
  Partials                   217      217           

Flag	Coverage Δ
app	45.72% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mjhuff]

Cool, seems reasonable to me!

[SyntaxColoring]

Seems sensible as long as this doesn’t make linting take too much longer from the extra build-ts. Anecdotally I think it’ll probably be fine. TY!

[sfoster1]

Seems sensible as long as this doesn’t make linting take too much longer from the extra build-ts. Anecdotally I think it’ll probably be fine. TY!

tsc caches very aggressively, so the first time you run it will take a couple minutes but it's quite fast thereafter.