feat(api): add StopVacuum command by caila-marashaj · Pull Request #21111 · Opentrons/opentrons

caila-marashaj · 2026-03-25T17:33:11Z

Overview

First Vacuum Module protocol engine command WOO

This implements the StopVacuum command, and completes the backend wiring necessary to run it.

Review Requests

I figured a natural state_update that might result from this command is specifying to the protocol engine whether the pump is running, but this doesn’t need to be used yet so I’m not sure if it’s necessary. lmk if I should take it out.

github-actions · 2026-03-25T18:15:44Z

A PR has been opened to address analyses snapshot changes. Please review the changes here: #21112

sfoster1

Could things outside the control of the engine change the pump-engaged state? Like is the engine in control of that, or is it observing it?

github-actions · 2026-03-25T18:52:56Z

A PR has been opened to address analyses snapshot changes. Please review the changes here: #21112

sfoster1

oh we need to do a schema update!

vegano1

Nice! thank you!

sfoster1

all those analysis snapshots seem to be going from working to failing, since they have -100k lines each

sfoster1 · 2026-03-25T20:25:02Z

@@ -1,7 +1,7 @@
 {


hey uhhhhh what's goin on here

I have no idea, that was in some automated fix

codecov · 2026-03-26T17:35:50Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.06%. Comparing base (21d8355) to head (d106478).
⚠️ Report is 3 commits behind head on edge.

Additional details and impacted files

@@           Coverage Diff           @@
##             edge   #21111   +/-   ##
=======================================
  Coverage   57.06%   57.06%           
=======================================
  Files        3970     3970           
  Lines      325506   325506           
  Branches    46350    46350           
=======================================
  Hits       185743   185743           
  Misses     139544   139544           
  Partials      219      219

Flag	Coverage Δ
app	`45.11% <ø> (ø)`
protocol-designer	`19.97% <ø> (ø)`
step-generation	`5.69% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-03-26T17:37:33Z

A PR has been opened to address analyses snapshot changes. Please review the changes here: #21123

github-actions · 2026-03-30T15:07:25Z

A PR has been opened to address analyses snapshot changes. Please review the changes here: #21123

github-actions · 2026-03-30T15:12:34Z

A PR has been opened to address analyses snapshot changes. Please review the changes here: #21123

github-actions · 2026-03-30T16:12:45Z

A PR has been opened to address analyses snapshot changes. Please review the changes here: #21143

github-actions · 2026-04-02T19:33:06Z

A PR has been opened to address analyses snapshot changes. Please review the changes here: #21143

…#21123)

fixed analysis errors + removed analysis result changes

caila-marashaj marked this pull request as ready for review March 25, 2026 18:10

caila-marashaj added the gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails label Mar 25, 2026

github-actions bot mentioned this pull request Mar 25, 2026

fix(analyses-snapshot-testing): heal stop-vacuum-pe-command snapshots #21112

Merged

sfoster1 requested changes Mar 25, 2026

View reviewed changes

Comment thread api/src/opentrons/protocol_engine/commands/vacuum_module/stop_vacuum.py Outdated

Comment thread api/src/opentrons/protocol_engine/commands/vacuum_module/stop_vacuum.py Outdated

caila-marashaj requested a review from sfoster1 March 25, 2026 19:00

caila-marashaj added gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails and removed gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails labels Mar 25, 2026

sfoster1 requested changes Mar 25, 2026

View reviewed changes

vegano1 approved these changes Mar 25, 2026

View reviewed changes

sfoster1 previously requested changes Mar 25, 2026

View reviewed changes

caila-marashaj force-pushed the stop-vacuum-pe-command branch from 2a2ed4d to c7247a3 Compare March 26, 2026 17:29

caila-marashaj requested review from a team as code owners March 26, 2026 17:29

caila-marashaj requested review from ncdiehl11 and removed request for a team March 26, 2026 17:29

caila-marashaj temporarily deployed to pd-non-prod March 26, 2026 17:35 — with GitHub Actions Inactive

github-actions bot mentioned this pull request Mar 26, 2026

fix(analyses-snapshot-testing): heal stop-vacuum-pe-command snapshots #21123

Merged

caila-marashaj force-pushed the stop-vacuum-pe-command branch from c7247a3 to dfac9cc Compare March 30, 2026 14:59

caila-marashaj temporarily deployed to pd-non-prod March 30, 2026 15:12 — with GitHub Actions Inactive

caila-marashaj temporarily deployed to pd-non-prod March 30, 2026 15:21 — with GitHub Actions Inactive

caila-marashaj temporarily deployed to pd-non-prod March 30, 2026 16:05 — with GitHub Actions Inactive

github-actions bot mentioned this pull request Mar 30, 2026

fix(analyses-snapshot-testing): heal stop-vacuum-pe-command snapshots #21143

Open

caila-marashaj force-pushed the stop-vacuum-pe-command branch from 270c54f to ecd2fae Compare April 2, 2026 19:24

caila-marashaj temporarily deployed to pd-non-prod April 2, 2026 19:33 — with GitHub Actions Inactive

caila-marashaj and others added 11 commits April 3, 2026 01:01

StopVacuum command linting

de413a8

add test

f9d77b3

pasta :(

b9ec437

update cmd schema

154d1b9

update command schema

3bc1f12

format js i suppose

2f67504

fix(analyses-snapshot-testing): heal stop-vacuum-pe-command snapshots (…

7163b9b

…#21123)

analyses?

4e8eb20

update vm substate after commands

dd3897f

modules fix

c1e95b2

revert css changes

d106478

caila-marashaj force-pushed the stop-vacuum-pe-command branch from ecd2fae to d106478 Compare April 3, 2026 05:07

caila-marashaj temporarily deployed to pd-non-prod April 3, 2026 05:12 — with GitHub Actions Inactive

caila-marashaj removed the gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails label Apr 3, 2026

caila-marashaj merged commit 7bd2767 into edge Apr 3, 2026
136 checks passed

Conversation

caila-marashaj commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Review Requests

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

sfoster1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

sfoster1 left a comment

Choose a reason for hiding this comment

Uh oh!

vegano1 left a comment

Choose a reason for hiding this comment

Uh oh!

sfoster1 left a comment

Choose a reason for hiding this comment

Uh oh!

sfoster1 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

caila-marashaj Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

caila-marashaj commented Mar 25, 2026 •

edited

Loading

codecov bot commented Mar 26, 2026 •

edited

Loading