fix(shared-data): fix lld for 20uL tips on p50S#21161
Closed
alexjoel42 wants to merge 1 commit intochore_release-9.0.0from
Closed
fix(shared-data): fix lld for 20uL tips on p50S#21161alexjoel42 wants to merge 1 commit intochore_release-9.0.0from
alexjoel42 wants to merge 1 commit intochore_release-9.0.0from
Conversation
geometry p50S for 3_5.json does not have lld for 20uL tips like it should fix RQA5286
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore_release-9.0.0 #21161 +/- ##
====================================================
Coverage 55.85% 55.85%
====================================================
Files 3924 3924
Lines 328655 328655
Branches 48345 48345
====================================================
Hits 183582 183582
Misses 144856 144856
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing in favor of https://opentrons.slack.com/archives/C0A2RD1Q9NJ/p1775050886895499?thread_ts=1775000990.531859&channel=C0A2RD1Q9NJ&message_ts=1775050886.895499 thanks @mjhuff for taking this over the finish line 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geometry p50S for 3_5.json does not have lld for 20uL tips like it should
fix RQA5286 by adding lld
Overview
We didn't add lld even though our pipettes use
p50_single_v3.5so we get this error when attempting lldTest Plan and Hands on Testing
Test
Changelog
Run
200uL_20uL_tip_test.py and ensure LLD works
Review requests
@ryanthecoder
Risk assessment
There are probably better ways of handling this like updating the pipettes to
opentrons/shared-data/pipette/definitions/2/geometry/single_channel/p50/3_6.jsonbut this is the best I can do on short notice