Skip to content

fix(shared-data): add t20 lld settings to p50 version 3.5#21162

Merged
mjhuff merged 2 commits intochore_release-9.0.0from
shared-data_add-t20-3.4
Apr 6, 2026
Merged

fix(shared-data): add t20 lld settings to p50 version 3.5#21162
mjhuff merged 2 commits intochore_release-9.0.0from
shared-data_add-t20-3.4

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented Apr 1, 2026

Closes RQA-5286

Overview

Whoops, like like we missed adding t20 values to v3.5 for the P50 single channel.

Test Plan and Hands on Testing

Changelog

Tested using the following protocol:


from opentrons import protocol_api
metadata = {
    "protocolName": "20uL tip lld ",
}

requirements = {
    "robotType": "Flex",
    "apiLevel": "2.28"
}

def run(ctx: protocol_api.ProtocolContext):
    ctx.load_waste_chute()

    # --- Hardware & labware setup ---
    # If you hit KeyError: 't20', switch to "opentrons_flex_96_tiprack_50ul".
    tip_rack = ctx.load_labware("opentrons_flex_96_tiprack_20ul", "C1")

    reservoir = ctx.load_labware('nest_12_reservoir_15ml', 'C2')
    plate = ctx.load_labware('corning_96_wellplate_360ul_flat', 'D2')
    
    # MODIFIED: Load P50 Single-Channel Pipette
    pipette = ctx.load_instrument('flex_1channel_50', 'left', tip_racks=[tip_rack])

    # --- Liquid sensing + meniscus aspiration ---
    ctx.comment("Measuring liquid height in reservoir A1, then aspirating at the meniscus...")

    source_well = reservoir["A1"]
    dest_well = plate["A5"]

    liquid_1 = ctx.define_liquid(name="liquid_1", display_color="#000000")
    source_well.load_liquid(liquid_1, volume=10000)

    pipette.pick_up_tip()

    pipette.measure_liquid_height(source_well)
    pipette.aspirate(volume=10, location=source_well.meniscus(z=-1))
    pipette.dispense(volume=10, location=dest_well)

    pipette.drop_tip()

Review requests

  • Can we quickly audit and confirm that all other definitions are correct, in particular, should we support 8 Channel P1000s?

Risk assessment

  • very low, assuming we want the pipette to support t20s.

@mjhuff mjhuff requested a review from ryanthecoder April 1, 2026 13:41
@mjhuff mjhuff requested review from a team as code owners April 1, 2026 13:41
@mjhuff mjhuff requested review from jerader and removed request for a team April 1, 2026 13:41
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.85%. Comparing base (5c32ad7) to head (1535bca).
⚠️ Report is 5 commits behind head on chore_release-9.0.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-9.0.0   #21162      +/-   ##
=======================================================
- Coverage                56.03%   55.85%   -0.18%     
=======================================================
  Files                     3924     3924              
  Lines                   328722   328655      -67     
  Branches                 48345    48345              
=======================================================
- Hits                    184189   183582     -607     
- Misses                  144311   144856     +545     
+ Partials                   222      217       -5     
Flag Coverage Δ
app 45.72% <ø> (-0.22%) ⬇️
protocol-designer 19.67% <ø> (ø)
step-generation 5.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mjhuff mjhuff removed the request for review from jerader April 1, 2026 13:46
Co-authored-by: Alex Joel <alex.copperman@opentrons.com>
@mjhuff mjhuff force-pushed the shared-data_add-t20-3.4 branch from db20121 to 9bac602 Compare April 1, 2026 13:54
Copy link
Copy Markdown
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good

@mjhuff mjhuff merged commit 44b37a2 into chore_release-9.0.0 Apr 6, 2026
124 checks passed
@mjhuff mjhuff deleted the shared-data_add-t20-3.4 branch April 6, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants