Skip to content

fix(protocol-designer, shared-data): correct 384 plate well selection to every other well#21183

Merged
rclarke0 merged 10 commits intochore_release-pd-8.10.0from
RQA-5294
Apr 3, 2026
Merged

fix(protocol-designer, shared-data): correct 384 plate well selection to every other well#21183
rclarke0 merged 10 commits intochore_release-pd-8.10.0from
RQA-5294

Conversation

@rclarke0
Copy link
Copy Markdown
Contributor

@rclarke0 rclarke0 commented Apr 2, 2026

Overview

Selects every other well when a liquid handling step occurs in a 384 well plate.

Also included minor fix to text styling in pipette nozzle selector

Test Plan and Hands on Testing

Screenshot 2026-04-02 at 4 14 14 PM

Changelog

  • fixed text size and subtext in NozzleSelector
  • created a util that skips every other well in a list of wells to be used for 384 plates when using getEntireWellSelection
  • adjusted util in getWellNamePerMultiTip to skip every other well when 384 plate in row and partial column configuration

Review requests

  • severity of shared-data edit. It looks like this is util is primarily used in pd and step generation, any concerns with this change

Risk assessment

  • high, edits util in shared-data

Closes RQA-5301, RQA-5294, RQA-5295, RQA-5296

@rclarke0 rclarke0 requested a review from a team as a code owner April 2, 2026 20:15
@rclarke0 rclarke0 requested review from ncdiehl11 and removed request for a team April 2, 2026 20:15
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 50.68493% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.51%. Comparing base (2fcf1f2) to head (ec2053f).
⚠️ Report is 3 commits behind head on chore_release-pd-8.10.0.

Files with missing lines Patch % Lines
shared-data/js/helpers/getWellNamePerMultiTip.ts 43.33% 17 Missing ⚠️
...PipetteFields/NozzleAndWellSelectionModal/utils.ts 72.72% 9 Missing ⚠️
...ields/NozzleAndWellSelectionModal/WellSelector.tsx 0.00% 4 Missing ⚠️
...StepForm/PipetteFields/TipSelectionWizard/utils.ts 0.00% 4 Missing ⚠️
...zleAndWellSelectionModal/PipetteNozzleSelector.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           chore_release-pd-8.10.0   #21183   +/-   ##
========================================================
  Coverage                    57.51%   57.51%           
========================================================
  Files                         3912     3912           
  Lines                       321091   321142   +51     
  Branches                     46280    46290   +10     
========================================================
+ Hits                        184678   184708   +30     
- Misses                      136192   136213   +21     
  Partials                       221      221           
Flag Coverage Δ
app 45.18% <4.10%> (-0.02%) ⬇️
protocol-designer 19.97% <50.68%> (+<0.01%) ⬆️
step-generation 5.69% <4.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/helpers/index.ts 63.50% <ø> (ø)
...zleAndWellSelectionModal/PipetteNozzleSelector.tsx 1.44% <0.00%> (ø)
...ields/NozzleAndWellSelectionModal/WellSelector.tsx 0.57% <0.00%> (+<0.01%) ⬆️
...StepForm/PipetteFields/TipSelectionWizard/utils.ts 26.46% <0.00%> (-0.28%) ⬇️
...PipetteFields/NozzleAndWellSelectionModal/utils.ts 73.96% <72.72%> (+0.23%) ⬆️
shared-data/js/helpers/getWellNamePerMultiTip.ts 78.21% <43.33%> (-11.26%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

return nozzleTextMapping[nozzleConfiguration](primaryNozzle)
}

export const skipEveryOtherWell = (
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you also added this to shared-data so i think you can delete this?

Copy link
Copy Markdown
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work!

@rclarke0 rclarke0 merged commit bdac1a7 into chore_release-pd-8.10.0 Apr 3, 2026
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants