chore: run the key server in dev backend#21267
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #21267 +/- ##
=======================================
Coverage 57.27% 57.27%
=======================================
Files 3991 3991
Lines 327280 327280
Branches 46563 46563
=======================================
Hits 187451 187451
Misses 139610 139610
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
We can use mitmproxy to terminate tls! the best way is to run a second mitmproxy, like we run a second nginx, and feed it the certs generated by the key-server. We need a little stuff in the key-server to support this because mitmproxy wants the whole bundle of tls cert, tls key, and ca cert in a single PEM (one PEM can contain multiple entities) and then we can "notify" of configuration changes by touching the main mitmproxy script since it has hot module reload. Probably. Nobody's going to run their dev backend instance for 3 years anyway. Closes EXEC-2524
ac79b5a to
16da6b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use mitmproxy to terminate tls! the best way is to run a second mitmproxy, like we run a second nginx, and feed it the certs generated by the key-server. We need a little stuff in the key-server to support this because mitmproxy wants the whole bundle of tls cert, tls key, and ca cert in a single PEM (one PEM can contain multiple entities) and then we can "notify" of configuration changes by touching the main mitmproxy script since it has hot module reload. Probably. Nobody's going to run their dev backend instance for 3 years anyway.
Closes EXEC-2524
Test Plan and Hands on Testing
dev-backendhttps://localhost:32313/health