feat(catalog): implement catalog list with pagination and loading states#613
Merged
Perdolique merged 1 commit intomasterfrom Apr 15, 2026
Merged
feat(catalog): implement catalog list with pagination and loading states#613Perdolique merged 1 commit intomasterfrom
Perdolique merged 1 commit intomasterfrom
Conversation
- ✨ Implement full catalog browse page with item table and pagination - ✨ Add loading overlay during page transitions (status live region) - ✨ Add initial load, empty, error, and out-of-range-page states - ✨ Add catalog entry formatting utility (brand/category display) - ✅ Add E2E tests for catalog list page (browsing, pagination, loading) - ✅ Add unit tests for catalog entry formatting utility - ♻️ Update shared constants, validation schemas, session utils - 📚 Update plan docs: mark catalog list iteration complete
🎉 Deployed to Cloudflare!
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the functional catalog list page, replacing the previous placeholder. It introduces a comprehensive CSS reset, refines component styling for buttons and dialogs, and adds utility functions for route state management. The backend items API is updated to provide stable pagination through explicit ordering and limit clamping. Additionally, the project roadmap is updated, and new unit and E2E tests are included to ensure the reliability of the catalog browsing flow. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the catalog browsing page ("Catalog list UI – URL-parity" iteration) with a full-featured item list table, pagination, and all required UI states.
Changes
Catalog browse page (
app/pages/catalog/index.vue)role="status"live region (accessible name fix:aria-label="Loading page")New utility (
app/utils/catalog.ts)formatCatalogEntryhelper for consistent brand/category display across the UIAPI & server
server/api/equipment/items/index.get.ts: handler improvementsserver/utils/session.ts,server/utils/validation/schemas.ts: session and validation updatesshared/constants.ts: shared constants addedComponents & styles
app/assets/styles/Tests
tests/playwright/catalog/catalog-entry-list.test.ts— browsing, pagination, loading states (11 tests, all passing)app/utils/__tests__/catalog.test.ts— catalog entry formatting utilityDocs
AGENTS.md: architecture notes updateplan/: roadmap updated, catalog list iteration marked complete