Open
Conversation
Collaborator
|
When chatting offline we decided to revisit this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds three things:
I encountered these things while testing the diffengine backend.
The fix is actually upstream in the converters, but I thought I would add some tests to the diffengine to make it a bit more robust.
The right matmul bug was encountered when doing
(1,n) @ (n)upstream, and the right hand argument's shape would be incorrectly converted to(1,n). I now make it so there's a special case to detect when a 1d array appears in either a LHS or RHS of a matmul.