Skip to content

[WARP] Fix misc UI thread safety issues#8112

Open
emesare wants to merge 2 commits intodevfrom
test_warp_ui_safety_0
Open

[WARP] Fix misc UI thread safety issues#8112
emesare wants to merge 2 commits intodevfrom
test_warp_ui_safety_0

Conversation

@emesare
Copy link
Copy Markdown
Member

@emesare emesare commented Apr 20, 2026

  1. Not holding mutex when clearing fetchers processed guids
  2. Not managing the lifetime of the fetchers background thread correctly on current function navigation

Fixes #8111

1. Not holding mutex when clearing fetchers processed guids
2. Not managing the lifetime of the fetchers background thread correctly on current function navigation

Fixes #8111
@emesare emesare requested a review from bdash April 20, 2026 20:21
@emesare emesare self-assigned this Apr 20, 2026
Comment thread plugins/warp/ui/matches.cpp
These lambdas execute on main thread so as long as it is checked before use in the lambda it is safe
@emesare emesare added this to the Krypton milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash due to null dereference in lambda within WarpCurrentFunctionWidget::SetCurrentFunction

2 participants