Skip to content

Add cdef type declarations and inline upgrade check in HTTP parser #12321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bdraco wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −2
Draft

Add cdef type declarations and inline upgrade check in HTTP parser #12321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97af201
Add cdef type declarations and inline upgrade check in HTTP parser
bdraco Apr 6, 2026
dc99fd7
Add changelog for #12321
bdraco Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES/12321.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Added ``cdef`` type declarations and inlined the upgrade check in the HTTP parser
-- by :user:`bdraco`.
6 changes: 4 additions & 2 deletions aiohttp/_http_parser.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,9 @@ cdef class HttpParser:
self._has_value = True

cdef _on_headers_complete(self):
cdef str h_upg
cdef str enc

self._process_header()

should_close = not cparser.llhttp_should_keep_alive(self._cparser)
Expand All @@ -457,8 +460,7 @@ cdef class HttpParser:

if self._cparser.type == cparser.HTTP_REQUEST:
h_upg = headers.get("upgrade", "")
allowed = upgrade and h_upg.isascii() and h_upg.lower() in ALLOWED_UPGRADES
if allowed or self._cparser.method == cparser.HTTP_CONNECT:
if (upgrade and h_upg.isascii() and h_upg.lower() in ALLOWED_UPGRADES) or self._cparser.method == cparser.HTTP_CONNECT:
self._upgraded = True
else:
if upgrade and self._cparser.status_code == 101:
Expand Down
Loading