Skip to content

GH-48712: [R] "Invalid metadata$r" warning#49608

Merged
thisisnic merged 1 commit intoapache:mainfrom
thisisnic:GH-48712-metadata
Apr 11, 2026
Merged

GH-48712: [R] "Invalid metadata$r" warning#49608
thisisnic merged 1 commit intoapache:mainfrom
thisisnic:GH-48712-metadata

Conversation

@thisisnic
Copy link
Copy Markdown
Member

@thisisnic thisisnic commented Mar 27, 2026

Rationale for this change

Warnings issued due to placeholder in the path when converting from schema -> Table -> data.frame

What changes are included in this PR?

Use to_data_frame() method which doesn't use placeholder.

Are these changes tested?

Yes

Are there any user-facing changes?

Yes - warning no longer issued

@thisisnic thisisnic requested a review from jonkeane as a code owner March 27, 2026 15:38
@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #48712 has been automatically assigned in GitHub to PR creator.

@thisisnic
Copy link
Copy Markdown
Member Author

Test failure R / rhub/ubuntu-gcc12:latest (pull_request) appears to be due to rlang on R 4.6 issues - we can always use dev rlang if needed.

@thisisnic
Copy link
Copy Markdown
Member Author

@jonkeane - got time to give this a look over?

Copy link
Copy Markdown
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure I follow why this suddenly(?) became a problem, but this is totally fine with me

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 10, 2026
@thisisnic thisisnic merged commit 66306ae into apache:main Apr 11, 2026
16 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Apr 11, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 66306ae.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 18 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants