Skip to content

fix: inconsistency in sorted view#733

Merged
proost merged 4 commits intoapache:mainfrom
proost:fix-inconsistency-in-sorted-view
Apr 14, 2026
Merged

fix: inconsistency in sorted view#733
proost merged 4 commits intoapache:mainfrom
proost:fix-inconsistency-in-sorted-view

Conversation

@proost
Copy link
Copy Markdown
Member

@proost proost commented Apr 10, 2026

I try to make consistency in docs and implementation.

  1. Docs said raising IllegarArgumentException when empty, but actual is SketchesArgumentException.
  2. getMaxItem and getMinItem not raise expected exception.

@proost proost requested a review from leerho April 10, 2026 08:27
@proost proost self-assigned this Apr 10, 2026
Copy link
Copy Markdown
Member

@leerho leerho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@proost proost merged commit 9255b50 into apache:main Apr 14, 2026
7 checks passed
@proost proost deleted the fix-inconsistency-in-sorted-view branch April 14, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants