arduino-uno-q: install USB gadget scripts unconditionally in BSP

[SuperKali]

Summary

Fix Ubuntu builds failing with `Failed to enable unit, unit usbgadget-rndis.service does not exist` on CI.

The BSP package is built once per board+branch and cached across all distributions. Conditioning the installation on `DISTRIBUTION` inside a `post_family_tweaks_bsp__` hook causes the CI to cache a BSP built for Debian (without gadget files), then reuse it for Ubuntu builds where `systemctl enable usbgadget-rndis.service` fails because the service file is missing in the cached BSP.

This is why no other board uses `DISTRIBUTION` checks in `post_family_tweaks_bsp__` — they only use them in `pre_customize_image__` which runs per-distro.

Fix

Install the USB gadget files unconditionally in the BSP (they're harmless if unused) and keep the service enablement conditional in `post_family_tweaks__` where `DISTRIBUTION` can be reliably checked per-image.

Test plan

• Log confirms the issue: https://paste.armbian.com/zuzopofuqa
• CI builds should pass for both Debian Trixie and Ubuntu Noble

Summary by CodeRabbit

• Bug Fixes
  • Improved Arduino Uno USB gadget functionality to work more consistently across different Linux distributions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The post_family_tweaks_bsp__arduino-uno-q_usb_gadget() function in Arduino Uno Q board configuration was modified to install USB gadget network scripts and service unit files unconditionally rather than conditionally based on distribution type. Updated comments document that BSP artifacts are cached across distributions.

Changes

Cohort / File(s)	Summary
Arduino Uno Q USB Gadget BSP config/boards/arduino-uno-q.csc	Removed conditional return logic from post_family_tweaks_bsp__arduino-uno-q_usb_gadget() to unconditionally install USB gadget files. Updated comments clarifying BSP artifact caching across distros and service enabling behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A gadget takes flight without condition's string,
USB flows free across each distro wing,
Cached artifacts dance, no checks in between,
Arduino's now simpler—pure and serene!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: moving USB gadget script installation from conditional to unconditional in the BSP function for arduino-uno-q.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!