Fix issue when polling for CloudFormation events#432
Merged
Conversation
…e deploy-serverless command was invoked
ashishdhingra
approved these changes
Mar 6, 2026
sankettangade
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Noticed that when I was using the
deploy-serverlesscommand when it polls for CloudFormation events it should only be showing events that were created sincedeploy-serverlesswas invoked but it was showing events in the past. I'm guessing this was a subtle bug introduced when we updated to V4 of the AWS SDK where now allDateTimeare returned back from the SDK in UTC.Corrected the filtering code to do the comparisons using UTC.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.