Conversation
joshfriend
changed the title
joshfriend
force-pushed
the
dd-log-forwarding
branch
3 times, most recently
from
a53eee1 to
5bbc346
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba91423563
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| slog.Warn("failed to open Datadog log file, DD logging disabled", "path", cli.DDLogFile, "error", err) | ||
| } | ||
| defer ddCleanup() | ||
| kctx.BindTo(ddLog, (**gradlecache.DDLog)(nil)) |
There was a problem hiding this comment.
This change only creates and binds ddLog, but no execution path actually writes to it: DDLog is added to config structs (gradlecache/restore.go and gradlecache/save.go) and then never used by Restore, RestoreDelta, Save, or SaveDelta. As a result, setting DD_LOG_PATH opens a file but produces no telemetry events, so Datadog file tailing gets nothing despite the new CLI flag promising log forwarding.
Useful? React with 👍 / 👎.
Add a DDLog logger that writes JSON to a file tailed by the Datadog Agent, configured via DD_LOG_PATH.
joshfriend
force-pushed
the
dd-log-forwarding
branch
from
5bbc346 to
6b0d04a
Compare
joshfriend
changed the title
1 participant
Add a DDLog logger that writes JSON to a file tailed by the Datadog
Agent, configured via
DD_LOG_PATH