Conversation
Bumps the Rspack catalog to 2.0.0 and applies the migration: - Node minimum bumped to 22.12.0 (Rspack 2 requirement) - Convert clerk-js rspack.config.js to .mjs (Rspack 2 core is pure ESM) - Rename output.libraryTarget to output.library.type (8 sites) - Move experiments.cache to top-level cache - Drop --analyze CLI flag (removed in v2; Rsdoctor remains for analysis) - Bump @rsdoctor/rspack-plugin to 1.5.x - Add @rspack/dev-server as a direct dep (no longer bundled with @rspack/cli) Both packages build green across all variants.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2188490 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughThis pull request upgrades the project to Rspack 2 and updates the minimum Node.js version to 22.12.0. It includes updating Node version requirements in Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/rspack.config.mjs (1)
2-518:⚠️ Potential issue | 🟠 MajorMerge blocker: no test coverage/verification for a build-system migration
This PR changes core bundling behavior (Rspack major version, config format, output library config, cache semantics) but includes no added/updated tests or automated verification in the change set. Please add and run migration-focused build/test coverage (at least smoke coverage across the declared variants) before merge.
As per coding guidelines, "If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/clerk-js/rspack.config.mjs` around lines 2 - 518, The PR introduces a major rspack-based bundling change but lacks migration/verification tests; add automated smoke tests that build and validate each declared variant (use variants object keys and entryForVariant, prodConfig and devConfig outputs) to CI: create test scripts that invoke the rspack build for clerkBrowser, clerkLegacyBrowser, clerkNative, clerk (ESM/CJS) and clerkNoRHC variants, assert successful exit and presence of expected output files (check output.filename/library type for commonjs/module/umd and chunking behavior), and add these tests to the repository CI pipeline so they run on PRs before merge.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/rspack-2-upgrade.md:
- Line 6: Add a CI-backed smoke test that verifies the Rspack 2 build/runtime
produces working bundles for the changed packages (`@clerk/clerk-js` and
`@clerk/ui`): create a new lightweight workflow or job (e.g.,
.github/workflows/smoke-rspack2.yml) that installs Node 22.12.0, runs the repo
build (npm/yarn build), runs a small script or test (e.g., a new script
"smoke:rspack2" in package.json) that imports the built bundles and asserts
basic runtime behavior (bundle loads without runtime errors and exports expected
symbols), and fail the job on any error; ensure the workflow runs on PRs and
include the new smoke script and any minimal test file under test/smoke or
tests/smoke so the CI actually exercises the new Rspack 2 output before merging.
In `@pnpm-workspace.yaml`:
- Around line 50-51: The exception currently whitelists the entire scope token
'@rspack/*', which is too broad; replace that entry with explicit
package+version pins for only the four newly added 2.0.0 packages (e.g.,
'@rspack/package-name@2.0.0') so only those exact artifacts bypass the 48h gate,
and keep the existing TODO comment about removing the pins once 2.0.0 is older
than 48h.
---
Outside diff comments:
In `@packages/clerk-js/rspack.config.mjs`:
- Around line 2-518: The PR introduces a major rspack-based bundling change but
lacks migration/verification tests; add automated smoke tests that build and
validate each declared variant (use variants object keys and entryForVariant,
prodConfig and devConfig outputs) to CI: create test scripts that invoke the
rspack build for clerkBrowser, clerkLegacyBrowser, clerkNative, clerk (ESM/CJS)
and clerkNoRHC variants, assert successful exit and presence of expected output
files (check output.filename/library type for commonjs/module/umd and chunking
behavior), and add these tests to the repository CI pipeline so they run on PRs
before merge.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 28eb5570-4ee1-4362-ae85-fc2dc0f1f50b
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
.changeset/rspack-2-upgrade.md.nvmrcpackage.jsonpackages/clerk-js/package.jsonpackages/clerk-js/rspack.config.mjspackages/clerk-js/turbo.jsonpackages/ui/package.jsonpackages/ui/rspack.config.jspnpm-workspace.yaml
| '@clerk/ui': patch | ||
| --- | ||
|
|
||
| Upgrade build tooling to Rspack 2. No user-facing API changes; the compiled bundle output is produced by Rspack 2's runtime. Also bumps the repo's minimum Node to 22.12.0 (Rspack 2 requirement). |
There was a problem hiding this comment.
Add smoke coverage for the Rspack 2 migration before merge.
This PR changes the toolchain/runtime that emits published @clerk/clerk-js and @clerk/ui bundles, but no tests were added or updated in the diff. Please land at least one CI-backed smoke path for the upgraded build/dev/analyzer flow before merging.
As per coding guidelines, "If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.changeset/rspack-2-upgrade.md at line 6, Add a CI-backed smoke test that
verifies the Rspack 2 build/runtime produces working bundles for the changed
packages (`@clerk/clerk-js` and `@clerk/ui`): create a new lightweight workflow or
job (e.g., .github/workflows/smoke-rspack2.yml) that installs Node 22.12.0, runs
the repo build (npm/yarn build), runs a small script or test (e.g., a new script
"smoke:rspack2" in package.json) that imports the built bundles and asserts
basic runtime behavior (bundle loads without runtime errors and exports expected
symbols), and fail the job on any error; ensure the workflow runs on PRs and
include the new smoke script and any minimal test file under test/smoke or
tests/smoke so the CI actually exercises the new Rspack 2 output before merging.
| # TODO: remove once rspack 2.0.0 is >48h old (published 2026-04-22) | ||
| - '@rspack/*' |
There was a problem hiding this comment.
Don't exempt the entire @rspack/* scope from the 48h quarantine.
This bypass is broader than the four 2.0.0 packages introduced here. If the TODO is missed, any freshly published @rspack/* package will skip the release-age gate as well.
Narrow the exception to the exact versions in this PR
- # TODO: remove once rspack 2.0.0 is >48h old (published 2026-04-22)
- - '@rspack/*'
+ # TODO: remove once rspack 2.0.0 is >48h old (published 2026-04-22)
+ - '@rspack/cli@2.0.0'
+ - '@rspack/core@2.0.0'
+ - '@rspack/dev-server@2.0.0'
+ - '@rspack/plugin-react-refresh@2.0.0'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # TODO: remove once rspack 2.0.0 is >48h old (published 2026-04-22) | |
| - '@rspack/*' | |
| # TODO: remove once rspack 2.0.0 is >48h old (published 2026-04-22) | |
| - '@rspack/cli@2.0.0' | |
| - '@rspack/core@2.0.0' | |
| - '@rspack/dev-server@2.0.0' | |
| - '@rspack/plugin-react-refresh@2.0.0' |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pnpm-workspace.yaml` around lines 50 - 51, The exception currently whitelists
the entire scope token '@rspack/*', which is too broad; replace that entry with
explicit package+version pins for only the four newly added 2.0.0 packages
(e.g., '@rspack/package-name@2.0.0') so only those exact artifacts bypass the
48h gate, and keep the existing TODO comment about removing the pins once 2.0.0
is older than 48h.
1 participant
Description
WIP — do not merge yet. First pass at upgrading the monorepo from Rspack 1.7.x to Rspack 2.0.0 so we can evaluate the migration end to end.
Both
@clerk/clerk-jsand@clerk/uibuild green on Rspack 2 across every variant (7 for clerk-js: browser, legacy browser, native, esm, esm-no-rhc, cjs, cjs-no-rhc; 3 for ui: browser, legacy, shared).What's in the diff
22.12.0(Rspack 2 requirement; previously22.11.0) in.nvmrcand rootengines.node.2.0.0for@rspack/cli,@rspack/core,@rspack/plugin-react-refresh. Added@rspack/dev-server@2.0.0— it's no longer bundled with@rspack/cliin v2.@rsdoctor/rspack-pluginbumped^0.4.13 → ^1.5.9in both packages for v2 compat.packages/clerk-js/rspack.config.js→.mjswith a CJS→ESM conversion. Rspack 2 core is pure ESM, and mixingrequire('@rspack/core')with the v2 shape is the exact pattern most likely to misbehave.output.libraryTarget: 'x'→output.library: { type: 'x' }across both configs (8 call sites) — the v1 shorthand is removed in v2.experiments.cache→ top-levelcache— the option graduated out ofexperimentsin v2.--analyzeCLI flag from thebuild:analyzescripts — removed in v2. Rsdoctor remains the analysis path.What I deliberately didn't touch
scripts/rspack-common.jsstays CJS. Node's CJS→ESM named-export interop handles it from both configs fine.webpackChunkNamemagic comments are still supported in v2 — no changes to the ~50 call sites inpackages/ui/src/**andpackages/clerk-js/src/core/auth/cookieSuffix.ts.integration/templates/**keep their ownengines.nodepins — they aren't in the pnpm workspace.Known WIP items before this can merge
minimumReleaseAgeExclude: ['@rspack/*']entry inpnpm-workspace.yaml— Rspack 2.0.0 was published 16h before this PR and the repo requires 48h. Either wait out the window and drop the exclusion, or keep a justified exclusion.pnpm --filter @clerk/clerk-js dev:sandbox:serveneeds to be validated before landing.build:rsdoctorshould be exercised.Type of change