fix(tck): resolve capability test failures for extensions and push notifications#2
Open
sherryfox wants to merge 1 commit intoehsavoie:0.3-workflowsfrom
Open
fix(tck): resolve capability test failures for extensions and push notifications#2sherryfox wants to merge 1 commit intoehsavoie:0.3-workflowsfrom
sherryfox wants to merge 1 commit intoehsavoie:0.3-workflowsfrom
Conversation
…tifications - Default `extensions` to an empty list in `AgentCapabilities` to ensure it serializes as an array, fixing `test_capabilities_structure`. - Save `pushNotificationConfig` in `onMessageSend` for non-streaming messages, fixing `test_send_message_with_push_notification_config`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extensionsto an empty list inAgentCapabilitiesto ensure it serializes as an array, fixingtest_capabilities_structure.pushNotificationConfiginonMessageSendfor non-streaming messages, fixingtest_send_message_with_push_notification_configFailures before the fixes:
After the fixes all tests are passing: