Allow treating /_virtual_includes/ and bazel-out/ as -isystem#53
Open
lalten wants to merge 2 commits intoerenon:masterfrom
Open
Allow treating /_virtual_includes/ and bazel-out/ as -isystem#53lalten wants to merge 2 commits intoerenon:masterfrom
lalten wants to merge 2 commits intoerenon:masterfrom
Conversation
lalten
force-pushed
the
virtual-and-generated-includes-as-isystem
branch
from
0c54dfa to
f1d6a83
Compare
Contributor
Author
|
ping on this @erenon, wdyt? |
Owner
|
Hi, since a recent change, HeaderFilterRegex is no longer recommended: f43f9d6 Instead, lib headers are added automatically. Does this affect this change? re skylib: I'd like to keep this project dependency free as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #32, but as opt-in behavior. Additionally allow ignoring generated includes in bazel-out/
The opt-in part is handled via
bool_flags, which needs Skylib.