service: add optional controlling TTY via tty: stanza#488
service: add optional controlling TTY via tty: stanza#488Ollie-Gutierrez wants to merge 4 commits intofinit-project:masterfrom
Conversation
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Some minor comments only, other than that it looks good! 💪 Looking forward to getting this merged, with docs 😊
|
I've addressed both your comments, and also added some documentation and a section on the man page. I put the docs in |
|
can you please update the luks example from https://finit-project.github.io/switchroot/?h=switch#example-initramfs-finitconf? |
|
Done, can't believe I forgot that considering it's the main reason for the pr |
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Very nice work on this! As a final touch, please squash the code and doc commits (so we get one for code and one for docs) then we can merge! 😃
3 participants
Adds a
tty:<dev>keyword for run/task/service stanzas to give them a controlling terminal. I decided to separate this from the prepare_tty helper as that prepares some extra stuff for getty/login which I don’t think we need here, though I’d be interested what you think regarding that. I also tried to keep compatibility withlog:. Everything works in my tests and I’ll look into writing some short documentation if you’re happy with everything!I based this on a poc by @aanderse, which initially just reused prepare_tty. This also addresses finix-community/finix#53.