fix: Improve password store detection on Linux tiling WMs#2785
fix: Improve password store detection on Linux tiling WMs#2785BlueManCZ wants to merge 1 commit intogitify-app:mainfrom
Conversation
|
Should this fix be upstream in electron itself? |
|
After digging deeper, I found that Electron has actually addressed this upstream in electron/electron#49054, which closes both electron/electron#39789 and electron/electron#47436. The fix introduces new async The migration on Gitify's side should be minimal — literally changing two lines in So there are two options:
|
|
Thanks for triaging further. Let's wait for v42 |
Summary
On Linux tiling WMs (Hyprland, Sway, i3, etc.), Electron's
safeStorageAPI fails to detect the correct password storage backend, even when a keyring likegnome-keyringis installed and running. This causes login to fail withEncryption is not available.The root cause is that Electron selects the backend based on the
XDG_CURRENT_DESKTOPenvironment variable. When it doesn't match a known desktop environment, it falls back tobasic_textand reportsisEncryptionAvailable: false-- despiteorg.freedesktop.secretsbeing available on D-Bus.This PR adds a startup check that queries D-Bus for an active Secret Service provider. If one is found and the user hasn't explicitly passed
--password-store, it sets--password-store=gnome-libsecretso Electron uses the correct backend.Details
execFileSyncto calldbus-send-- no shell spawned, no new dependencies--password-store=...flag the user passesRelated
Tested on