feat(gooddata-sdk): [AUTO] Add JsonApiAgent CRUD entity and DeclarativeAgent/DeclarativeAgents models#1564
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
Conversation
…veAgent/DeclarativeAgents models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added CatalogAgent entity model with full CRUD service methods for the new JsonApiAgent endpoints. Wired AIAgentsApi (from the auto-generated client) into GoodDataApiClient and CatalogServiceBase, then added get_agent / list_agents / create_agent / update_agent / patch_agent / delete_agent methods to CatalogOrganizationService. All new classes are exported from gooddata_sdk.init. DeclarativeAgent/DeclarativeAgents from the diff are skipped — no generated client models exist for them and no layout API endpoint is present to call.
Impact: new_feature | Services:
gooddata-metadata-clientTickets: GDAI-1284
Files changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/agent.pypackages/gooddata-sdk/src/gooddata_sdk/client.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/catalog_service_base.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_agent.pyAgent decisions
Decisions (5)
AIAgentsApi vs EntitiesApi — Use standalone AIAgentsApi imported directly from gooddata_api_client.api.ai_agents_api
DeclarativeAgent / DeclarativeAgents skipped — No SDK wrapper for DeclarativeAgent/DeclarativeAgents
from_api key names — Use snake_case keys in safeget calls inside from_api
Service location — Add agent methods to existing CatalogOrganizationService
Expose both PATCH and PUT — Provide both patch_agent and update_agent methods
Assumptions to verify (3)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/agent.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/src/gooddata_sdk/client.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/catalog_service_base.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/service.pypackages/gooddata-sdk/tests/catalog/test_catalog_agent.pySource commits (gdc-nas)
a544341Merge pull request #21553 from gooddata/ach/gdai-1522502429bMerge pull request #21309 from gooddata/ach/gdai-1370-agent-wiree1b236dMerge pull request #21241 from gooddata/ach/gdai-1370-result-fix19348b5Merge pull request #21542 from gooddata/ach/gdai-15224d55770Merge pull request #20464 from gooddata/js/GDAI-1284OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow