feat(gooddata-sdk): [AUTO] Add alert trigger ONCE_PER_INTERVAL with interval granularity field#1568
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Add alert trigger ONCE_PER_INTERVAL with interval granularity field#1568yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…nterval granularity field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added CatalogAutomationAlert SDK wrapper class with new
intervalfield andONCE_PER_INTERVALtrigger support. Addedalertfield to CatalogDeclarativeAutomation. Exported CatalogAutomationAlert from the public API surface. Two unit tests added (no cassettes required).Impact: new_feature | Services:
gooddata-automation-client,gooddata-metadata-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/automation.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace.pyAgent decisions
Decisions (4)
condition and execution field types — Use dict[str, Any] for condition and execution in CatalogAutomationAlert
where to add CatalogAutomationAlert — Add CatalogAutomationAlert to existing automation.py alongside the other CatalogAutomation* classes
alert field previously absent from CatalogDeclarativeAutomation — Add alert: CatalogAutomationAlert | None = None to CatalogDeclarativeAutomation
from future import annotations — Added to automation.py (was missing before)
Assumptions to verify (2)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/automation.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace.pySource commits (gdc-nas)
fd55e3fMerge pull request #22089 from Tjev/cq-2090OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow