feat(gooddata-sdk): [AUTO] Add HLL data type, APPROXIMATE_COUNT operation, and HYPERLOGLOG label type#1570
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
Conversation
…tion, and HYPERLOGLOG label type
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
===========================================
+ Coverage 0.00% 78.66% +78.66%
===========================================
Files 158 230 +72
Lines 11048 15408 +4360
===========================================
+ Hits 0 12121 +12121
+ Misses 11048 3287 -7761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added HLL to ColumnDataType enum in gooddata-pipelines, and HYPERLOGLOG + AUXILIARY to GoodDataLabelType enum in gooddata-dbt. APPROXIMATE_COUNT was already present in gooddata-sdk's SIMPLE_METRIC_AGGREGATION and _AGGREGATION_CONVERSION. The gooddata-sdk declarative model fields (source_column_data_type, value_type) are typed as str | None without enum validators, so no SDK-core changes were needed.
Impact: enum_addition | Services:
gooddata-afm-client,gooddata-metadata-clientFiles changed
packages/gooddata-dbt/src/gooddata_dbt/dbt/base.pypackages/gooddata-pipelines/src/gooddata_pipelines/ldm_extension/models/custom_data_object.pyAgent decisions
Decisions (3)
APPROXIMATE_COUNT already present — No change to gooddata-sdk metric.py or visualization.py
gooddata-sdk core fields need no change — Left source_column_data_type and value_type fields as str | None without validation
GoodDataLabelType scope — Added both HYPERLOGLOG and AUXILIARY to GoodDataLabelType in gooddata-dbt
Assumptions to verify (3)
Layers touched (1)
packages/gooddata-dbt/src/gooddata_dbt/dbt/base.pypackages/gooddata-pipelines/src/gooddata_pipelines/ldm_extension/models/custom_data_object.pySource commits (gdc-nas)
03cb7b6Merge pull request #21512 from pcerny/pce/cq-2118_hll_sr6faf4e2Merge pull request #21484 from pcerny/pce/cq-2118_hll_sre6d7adbMerge pull request #21592 from pcerny/pce/cq-2118_vertica_scan5ce05e5Merge pull request #22135 from gooddata/ine-hll-ff7ed4096Merge pull request #22170 from pcerny/pce/cq-2232_hll_colf24d083Merge pull request #22147 from pcerny/pce/cq-2227_dataset_auxiliarye35ed4cMerge pull request #20807 from gooddata/ine-cq-2014OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow