feat(gooddata-sdk): [AUTO] Add grandTotalsPosition field to tabular export Settings schema#1575
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Add grandTotalsPosition field to tabular export Settings schema#1575yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…xport Settings schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extended GrandTotalsPosition Literal type in request.py to include uppercase 'TOP' and 'BOTTOM' values added by the OpenAPI diff, and updated the parametrized test to cover the two new enum values.
Impact: new_feature | Services:
gooddata-export-client,gooddata-metadata-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/export/request.pypackages/gooddata-sdk/tests/export/test_export_service.pyAgent decisions
Decisions (2)
uppercase vs lowercase enum values — Add 'TOP' and 'BOTTOM' (uppercase) as additional valid values in GrandTotalsPosition Literal alongside existing lowercase values
scope of SDK change — Only update GrandTotalsPosition TypeAlias and corresponding test; no new classes needed
Assumptions to verify (3)
Risks (2)
Layers touched (2)
packages/gooddata-sdk/src/gooddata_sdk/catalog/export/request.pypackages/gooddata-sdk/tests/export/test_export_service.pySource commits (gdc-nas)
36a823efeat(tabular-exporter): respect grand-total-possition in PDFs in AD0f0ac6ffeat(tabular-exporter): respect grand-total-possition in PDFsOpenAPI diff
"Settings": { "properties": { + "grandTotalsPosition": { + "description": "Position of grand totals in the exported tabular data.", + "enum": ["TOP", "BOTTOM"], + "type": "string" + }, "mergeHeaders": { "type": "boolean" } } }Workflow run
Generated by SDK OpenAPI Sync workflow