feat(gooddata-pipelines): support tags, description and merge into existing LDM#1580
Merged
feat(gooddata-pipelines): support tags, description and merge into existing LDM#1580
Conversation
benkeanna
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1580 +/- ##
==========================================
+ Coverage 78.71% 78.83% +0.11%
==========================================
Files 230 230
Lines 15449 15486 +37
==========================================
+ Hits 12161 12208 +47
+ Misses 3288 3278 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janmatzek
requested changes
Apr 23, 2026
|
|
||
| ### Merging into an existing child workspace LDM | ||
|
|
||
| By default, `process` uploads only the declarative fragment built from your custom dataset definitions. For child workspaces that already inherit an LDM, you typically need to **merge** custom datasets and date instances into the current model instead of replacing it. |
Contributor
There was a problem hiding this comment.
This confused me a little bit about what to expect from the functionality. Would perhaps something like
By default, `process` overwrites the entire everything in child workspace LDM based on your inputs. By setting `merge_into_existing_ldm=True` you can change this behavior to append your inputs to existing child workspace LDM extensions. [...]
make it a bit clearer?
| manager._sdk.catalog_workspace.put_declarative_workspace.assert_not_called() | ||
|
|
||
|
|
||
| def test_relations_check_failure_and_revert( |
Contributor
There was a problem hiding this comment.
is there a reason to remove these tests?
| set, datasets that carry ``management_tag`` but are absent from the incoming | ||
| fragment are removed first (typical for tooling-owned extension datasets). | ||
|
|
||
| Inherited LDM objects that are not touched by the fragment remain unchanged. |
Contributor
There was a problem hiding this comment.
I think you cannot touch the inherited LDM objects anyway. Is this more about the preexisting extensions not being touched by the merge?
janmatzek
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://gooddata.atlassian.net/browse/MCMIC-2430