Skip to content

refactor: move java-common-protos to top level#12839

Draft
chingor13 wants to merge 27 commits intomainfrom
flatten-generated-modules
Draft

refactor: move java-common-protos to top level#12839
chingor13 wants to merge 27 commits intomainfrom
flatten-generated-modules

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Apr 17, 2026

Currently, the hermetic code generator can only move files to top level folders. Rather than changing the generator, we will move the generated code to the top level to also make it compatible with librarian.

Towards #12735

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IAM library configuration to iam-policy, adds an api_id, and introduces a new common-protos library entry in generation_config.yaml. It also adjusts the parent POM relative path in java-common-protos/pom.xml. Feedback focuses on maintaining alphabetical order for library entries, updating the display name for the IAM Policy library for consistency, and ensuring consistent string formatting by removing unnecessary quotes in the configuration file.

Comment thread generation_config.yaml
Comment thread generation_config.yaml
Comment thread generation_config.yaml Outdated
@chingor13 chingor13 marked this pull request as ready for review April 20, 2026 16:53
@chingor13 chingor13 requested a review from a team as a code owner April 20, 2026 16:53
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

@chingor13 chingor13 marked this pull request as draft April 20, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants